bpo-40131: Fix an example in the zipapp docs#19290
Merged
tirkarthi merged 1 commit intoApr 3, 2020
Merged
Conversation
Contributor
Author
|
This PR doesn't need a news entry. |
aeros
approved these changes
Apr 2, 2020
aeros
left a comment
Contributor
There was a problem hiding this comment.
Thanks for the PR @ZackerySpytz; LGTM. The archived output file (*.pyz) should certainly be in the argument position for the target, not source.
Also, this should be backported to 3.8 and 3.7, since the issue is also present on those branches.
tirkarthi
approved these changes
Apr 2, 2020
tirkarthi
left a comment
Member
There was a problem hiding this comment.
LGTM. Thanks @ZackerySpytz.
Contributor
|
Thanks @ZackerySpytz for the PR, and @tirkarthi for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7, 3.8. |
|
GH-19339 is a backport of this pull request to the 3.8 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Apr 3, 2020
) (cherry picked from commit bd6a4c3) Co-authored-by: Zackery Spytz <zspytz@gmail.com>
|
GH-19340 is a backport of this pull request to the 3.7 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Apr 3, 2020
) (cherry picked from commit bd6a4c3) Co-authored-by: Zackery Spytz <zspytz@gmail.com>
tirkarthi
pushed a commit
that referenced
this pull request
Apr 3, 2020
tirkarthi
pushed a commit
that referenced
this pull request
Apr 3, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://bugs.python.org/issue40131