bpo-38041: Refine IDLE Shell restart lines. #15709
Merged
Merged
Conversation
Pull restart line calculation into a separate module function. Add tests that currently pass.
Member
Author
|
Tal, I believe that this is ready and expect to merge it tomorrow, as indicated by the idlelib news entry. But take a look if you want and have time. |
taleinat
reviewed
Sep 6, 2019
taleinat
left a comment
Contributor
There was a problem hiding this comment.
I like this change overall. I made a few comments but nothing major.
Co-Authored-By: Tal Einat <taleinat+github@gmail.com>
Co-Authored-By: Tal Einat <taleinat+github@gmail.com>
Member
Author
|
I am up much later than I should be. Will finish revisions after sleeping. Thank you for the improvements. |
Contributor
|
Thanks @terryjreedy for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7, 3.8. |
|
GH-15719 is a backport of this pull request to the 3.8 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Sep 6, 2019
Restart lines now always start with '=' and never end with ' ' and fill the width of the window unless that would require ending with ' ', which could be wrapped by itself and possible confusing the user. (cherry picked from commit 38da805) Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
|
GH-15720 is a backport of this pull request to the 3.7 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Sep 6, 2019
Restart lines now always start with '=' and never end with ' ' and fill the width of the window unless that would require ending with ' ', which could be wrapped by itself and possible confusing the user. (cherry picked from commit 38da805) Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
miss-islington
added a commit
that referenced
this pull request
Sep 6, 2019
Restart lines now always start with '=' and never end with ' ' and fill the width of the window unless that would require ending with ' ', which could be wrapped by itself and possible confusing the user. (cherry picked from commit 38da805) Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
miss-islington
added a commit
that referenced
this pull request
Sep 6, 2019
Restart lines now always start with '=' and never end with ' ' and fill the width of the window unless that would require ending with ' ', which could be wrapped by itself and possible confusing the user. (cherry picked from commit 38da805) Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
lisroach
pushed a commit
to lisroach/cpython
that referenced
this pull request
Sep 10, 2019
Restart lines now always start with '=' and never end with ' ' and fill the width of the window unless that would require ending with ' ', which could be wrapped by itself and possible confusing the user.
DinoV
pushed a commit
to DinoV/cpython
that referenced
this pull request
Jan 14, 2020
Restart lines now always start with '=' and never end with ' ' and fill the width of the window unless that would require ending with ' ', which could be wrapped by itself and possible confusing the user.
websurfer5
pushed a commit
to websurfer5/cpython
that referenced
this pull request
Jul 20, 2020
Restart lines now always start with '=' and never end with ' ' and fill the width of the window unless that would require ending with ' ', which could be wrapped by itself and possible confusing the user.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Restart lines now always start with '=' and never end with ' ' and fill the width of the window unless that would require ending with ' ', which could be wrapped by itself and possible confusing the user.
https://bugs.python.org/issue38041