gh-155856: Rephrase doc for "iter" to avoid "collection" - #155857
gh-155856: Rephrase doc for "iter" to avoid "collection"#155857wjandrea wants to merge 1 commit into
Conversation
| second argument, the single argument must be an object that supports the | ||
| :term:`iterable` protocol (the :meth:`~object.__iter__` method) or | ||
| the :term:`sequence` protocol (the :meth:`~object.__getitem__` method with integer arguments |
There was a problem hiding this comment.
Can you avoid this diff and solely remove the word "collection" without reflowing the text please?
There was a problem hiding this comment.
Sorry, I made a typo in my initial commit. Let me redo it and get back to you. Converted to draft PR for now.
There was a problem hiding this comment.
Usually, we don't care about nice commit messages as maintainers will either rewrite them or remove them and use the PR title as the sole commit message
There was a problem hiding this comment.
In particular, we prefer not having force-pushes
There was a problem hiding this comment.
oops, sorry, I just did a force push. I don't really know what I'm doing with Git. Ready for review now.
There was a problem hiding this comment.
I did more than just reflow the text. I also changed the wording and added a link.
Documentation build overview
|
Fixes python#155856 - The term "collection" is misleading. Also add link to "sequence".
Fixes #155856 - The term "collection" is misleading.
Also add link to "sequence".
iter()doesn't require a "collection" #155856