gh-129382: Match venv API symlink defaults to the CLI - #155759
Open
zanieb wants to merge 4 commits into
Open
Conversation
Documentation build overview
|
Contributor
Author
|
cc @geofft |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Picking up #129493 which was targeting 3.14 but went stale.
In addition to the commentary in #129382 that it's surprising that this API currently differs from the defaults of
python -m venv, using copies of interpreters is generally problematic and should be discouraged. Some of the reasons for this are discussed in #129382, but there are also additional reports of issues and confusion:uv runuses wrong python interpreter inside virtualenv with copied python astral-sh/uv#21077This feels relatively low risk, as if the symlink fails, we will fallback to a copy.