Skip to content

bpo-26589: Add http status code 451#15413

Merged
rhettinger merged 5 commits into
python:masterfrom
rhettinger:http451
Aug 23, 2019
Merged

bpo-26589: Add http status code 451#15413
rhettinger merged 5 commits into
python:masterfrom
rhettinger:http451

Conversation

@rhettinger

@rhettinger rhettinger commented Aug 23, 2019 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Contributor

Previously given LGTM by R David Murray on 5/29/2016

https://bugs.python.org/issue26589

@rhettinger rhettinger added type-feature A feature request or enhancement needs backport to 3.8 labels Aug 23, 2019
tirkarthi
tirkarthi reviewed Aug 23, 2019
View reviewed changes
Comment thread Lib/http/__init__.py
'Request Header Fields Too Large',
'The server is unwilling to process the request because its header '
'fields are too large')
UNAVAILABLE_FOR_LEGAL_REASONS = (451,

@tirkarthi tirkarthi Aug 23, 2019

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add this constant to list of tested constants like the previously added constant MISDIRECTED_REQUEST : https://github.com/python/cpython/pull/2589/files#diff-4334c6b7e8fcfc88f2555f65fa7ab337R1358

@rhettinger rhettinger Aug 23, 2019

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

epicfaace
epicfaace reviewed Aug 23, 2019
View reviewed changes
Comment thread Doc/library/http.rst Outdated
``428`` ``PRECONDITION_REQUIRED`` Additional HTTP Status Codes :rfc:`6585`
``429`` ``TOO_MANY_REQUESTS`` Additional HTTP Status Codes :rfc:`6585`
``431`` ``REQUEST_HEADER_FIELDS_TOO_LARGE`` Additional HTTP Status Codes :rfc:`6585`
``451`` ``UNAVAILABLE_FOR_LEGAL_REASONS`` Status Code to Report Legal Obstacles :rfc:`7725`

@epicfaace epicfaace Aug 23, 2019

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps you should change it to the title of the rfc for consistency?

Suggested change
``451`` ``UNAVAILABLE_FOR_LEGAL_REASONS`` Status Code to Report Legal Obstacles :rfc:`7725`
``451`` ``UNAVAILABLE_FOR_LEGAL_REASONS`` An HTTP Status Code to Report Legal Obstacles :rfc:`7725`

@rhettinger rhettinger Aug 23, 2019

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay.

Comment thread Doc/library/http.rst
.. versionchanged:: 3.7
Added ``421 MISDIRECTED_REQUEST`` status code.

.. versionadded:: 3.8

@epicfaace epicfaace Aug 23, 2019

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be:

Suggested change
.. versionadded:: 3.8
.. versionadded:: 3.9

@rhettinger rhettinger Aug 23, 2019

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm backporting this to 3.8

Comment thread Lib/http/__init__.py Outdated
* RFC 7238: Permanent Redirect
* RFC 2295: Transparent Content Negotiation in HTTP
* RFC 2774: An HTTP Extension Framework
* RFC 7725: Status Code to Report Legal Obstacles

@epicfaace epicfaace Aug 23, 2019

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* RFC 7725: Status Code to Report Legal Obstacles
* RFC 7725: An HTTP Status Code to Report Legal Obstacles

@rhettinger rhettinger Aug 23, 2019

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay

tirkarthi
tirkarthi approved these changes Aug 23, 2019
View reviewed changes

@tirkarthi tirkarthi left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

@rhettinger rhettinger merged commit 8f080b0 into python:master Aug 23, 2019
@rhettinger rhettinger deleted the http451 branch August 23, 2019 17:19
@miss-islington

miss-islington commented Aug 23, 2019

Copy link
Copy Markdown
Contributor

Thanks @rhettinger for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖

@miss-islington

miss-islington commented Aug 23, 2019

Copy link
Copy Markdown
Contributor

Sorry @rhettinger, I had trouble checking out the 3.8 backport branch.
Please backport using cherry_picker on command line.
cherry_picker 8f080b09953a2d862de5c74edf414a54ea3dbea5 3.8

@miss-islington

miss-islington commented Aug 23, 2019

Copy link
Copy Markdown
Contributor

Thanks @rhettinger for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖

@bedevere-bot

bedevere-bot commented Aug 23, 2019

Copy link
Copy Markdown

GH-15436 is a backport of this pull request to the 3.8 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Aug 23, 2019
@rhettinger @miss-islington
bpo-26589: Add http status code 451 (pythonGH-15413)
50c352b 
(cherry picked from commit 8f080b0)

Co-authored-by: Raymond Hettinger <rhettinger@users.noreply.github.com>
rhettinger added a commit that referenced this pull request Aug 23, 2019
@miss-islington @rhettinger
bpo-26589: Add http status code 451 (GH-15413) (GH-15436)
761e5a7 
(cherry picked from commit 8f080b0)

Co-authored-by: Raymond Hettinger <rhettinger@users.noreply.github.com>
lisroach pushed a commit to lisroach/cpython that referenced this pull request Sep 10, 2019
@rhettinger @lisroach
bpo-26589: Add http status code 451 (pythonGH-15413)
cd88da4
DinoV pushed a commit to DinoV/cpython that referenced this pull request Jan 14, 2020
@rhettinger @DinoV
bpo-26589: Add http status code 451 (pythonGH-15413)
b1631b7
websurfer5 pushed a commit to websurfer5/cpython that referenced this pull request Jul 20, 2020
@rhettinger @websurfer5
bpo-26589: Add http status code 451 (pythonGH-15413)
ee52746
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tirkarthi tirkarthi tirkarthi approved these changes

@bitdancer bitdancer Awaiting requested review from bitdancer

@vadmium vadmium Awaiting requested review from vadmium

+1 more reviewer

@epicfaace epicfaace epicfaace left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@rhettinger rhettinger

Labels

type-feature A feature request or enhancement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@rhettinger @miss-islington @bedevere-bot @epicfaace @tirkarthi @the-knights-who-say-ni