gh-148286: Remove invalid test in test_decodeescape#153187
Open
StanFromIreland wants to merge 4 commits into
Open
gh-148286: Remove invalid test in test_decodeescape#153187StanFromIreland wants to merge 4 commits into
test_decodeescape#153187StanFromIreland wants to merge 4 commits into
Conversation
Member
|
Simply comment out the test. |
This reverts commit 9c29e17.
PyBytes_DecodeEscapetest_decodeescape
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is technically disallowed by the documentation of
PyBytes_DecodeEscape(added in 37e2762), which says:However, this was triggered by our test suite, which explicitly tests this case:
cpython/Lib/test/test_capi/test_bytes.py
Line 225 in 9c29e17
Should we also update the documentation? CC @ZeroIntensity (added docs) and @serhiy-storchaka (added test)