Skip to content

[WIP] gh-152090: Fix CALL_LIST_APPEND opcode error path#152091

Draft
vstinner wants to merge 1 commit into
python:mainfrom
vstinner:call_list_append
Draft

[WIP] gh-152090: Fix CALL_LIST_APPEND opcode error path#152091
vstinner wants to merge 1 commit into
python:mainfrom
vstinner:call_list_append

Conversation

@vstinner

@vstinner vstinner commented Jun 24, 2026

Copy link
Copy Markdown
Member

Clear arg since PyStackRef_AsPyObjectSteal(arg) converted arg to a dangling stack reference.

Clear arg since PyStackRef_AsPyObjectSteal(arg) converted arg to a
dangling stack reference.
@vstinner

Copy link
Copy Markdown
Member Author

@Fidget-Spinner @corona10: I don't think that stack_pointer[-1] = PyStackRef_NULL; is the correct way to clear arg in the error path, but I failed to find the right syntax to clear arg. Do you know how to do that?

Well, do you agree with my analysis of issue gh-152090 crash?

Also, so far, I failed to write a reliable reproducer for the bug.

@vstinner

Copy link
Copy Markdown
Member Author

JIT / x86_64-apple-darwin/clang (Debug) (pull_request): Failing after 4m

It looks like a network error:

==> Updating Homebrew...
error: RPC failed; curl 6 Recv failure: Operation timed out

Tests / macOS / build and test (macos-26) (pull_request): Failing after 13m

FAIL: test_tk_caret (test.test_tkinter.test_misc.MiscTest.test_tk_caret)

I created #152093 to track this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant