PCbuild/build.bat: pass command line parameters when building PGO#1510
Conversation
Custom msbuild properties passed as command line need to be passed too when calling `Build` when doing PGO build.
|
Hello, and thanks for your contribution! I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA). Unfortunately we couldn't find an account corresponding to your GitHub username on bugs.python.org (b.p.o) to verify you have signed the CLA. This is necessary for legal reasons before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue. Thanks again to your contribution and we look forward to looking at it! |
| if "%do_pgo%"=="true" ( | ||
| set conf=PGInstrument | ||
| call :Build | ||
| call :Build %1 %2 %3 %4 %5 %6 %7 %8 %9 |
There was a problem hiding this comment.
I'm a little concerned about the ^M disappearing from the line. Batch files are very fussy about line endings.
With confirmation that this doesn't break the line ending, I'm good with the fix.
In GitHub and on Linux using "git show", it seems like the diff changes the line ending. But it's a bug in these tools, there is no line change. I checked in vim and then with hexdump: 0x0d 0x0a (\r\n) for all lines ;-) |
|
Batch files with unix line endings works fine in Windows 10 even when calling labels. When opened with vim, the detected line endings are |
Custom msbuild properties passed as command line need to be passed too when calling
Buildwhen doing PGO build.