[3.14] gh-90949: expose Expat API to tune exponential expansion protections (GH-139368)#150496
Draft
StanFromIreland wants to merge 1 commit into
Draft
[3.14] gh-90949: expose Expat API to tune exponential expansion protections (GH-139368)#150496StanFromIreland wants to merge 1 commit into
StanFromIreland wants to merge 1 commit into
Conversation
… protections (pythonGH-139368) Expose the XML Expat 2.7.2 APIs to tune protections against "billion laughs" [1] attacks. The exposed APIs are available on Expat parsers, that is, parsers created by `xml.parsers.expat.ParserCreate()`, as: - `parser.SetBillionLaughsAttackProtectionActivationThreshold(threshold)`, and - `parser.SetBillionLaughsAttackProtectionMaximumAmplification(max_factor)`. This completes the work in f04bea4, and improves the existing related documentation. [1]: https://en.wikipedia.org/wiki/Billion_laughs_attack (cherry picked from commit 6661123) Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
This was referenced May 26, 2026
Documentation build overview
390 files changed ·
|
picnixz
reviewed
May 26, 2026
| self.assert_root_parser_failure(setter, 123.45) | ||
|
|
||
|
|
||
| @unittest.skipIf(expat.version_info < (2, 4, 0), "requires Expat >= 2.4.0") |
Member
There was a problem hiding this comment.
I think we had a recent issue where this check was not sufficient and tests needed to be disabled in another way using hasattr() checks. Can you check how it's currently done on main please?
picnixz
reviewed
May 26, 2026
Comment on lines
+1261
to
+1264
| return set_activation_threshold( | ||
| self, cls, threshold, | ||
| XML_SetBillionLaughsAttackProtectionActivationThreshold | ||
| ); |
Member
There was a problem hiding this comment.
There seem to be too many whitespaces here.
picnixz
reviewed
May 26, 2026
Comment on lines
+1298
to
+1300
| return set_maximum_amplification( | ||
| self, cls, max_factor, | ||
| XML_SetBillionLaughsAttackProtectionMaximumAmplification |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Expose the XML Expat 2.7.2 APIs to tune protections against "billion laughs" 1 attacks.
The exposed APIs are available on Expat parsers, that is, parsers created by
xml.parsers.expat.ParserCreate(), as:parser.SetBillionLaughsAttackProtectionActivationThreshold(threshold), andparser.SetBillionLaughsAttackProtectionMaximumAmplification(max_factor).This completes the work in f04bea4, and improves the existing related documentation.