gh-150355: Allow creating tasks in cancelled TaskGroup with cooperative cancellation#150357
Open
azibom wants to merge 1 commit into
Open
gh-150355: Allow creating tasks in cancelled TaskGroup with cooperative cancellation#150357azibom wants to merge 1 commit into
azibom wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
gh-150355: Allow create_task after tg.cancel() – cooperative cancellation
Problem:
After
tg.cancel(),create_task()raisesRuntimeError: TaskGroup is shutting down. The test TODO says this is not ideal – the task should run until the first await and then be cancelled.Solution:
Add
_explicitly_cancelledflag. On explicitcancel()the flag is set. Increate_task(), if_abortingand_explicitly_cancelledis true, the task is created normally and then scheduled for cancellation withcall_soon. This allows the synchronous code up to the firstawaitto run. Failure‑induced abort still raisesRuntimeError.Testing:
All 118 tests in
test_asyncio.test_taskgroupspass.