Skip to content

gh-150311: Fix minor issues in configure.ac for the CYGWIN port #150328

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Ar-maan05 wants to merge 2 commits into
base: main
Choose a base branch
from
+12 −8
Open

gh-150311: Fix minor issues in configure.ac for the CYGWIN port #150328

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2e439da
gh-150311: Fix minor issues in configure.ac for the CYGWIN port
Ar-maan05 May 24, 2026
98b301b
gh-150311: Add NEWS entry and regenerate configure
Ar-maan05 May 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions Misc/NEWS.d/next/Build/2026-05-24-12-30-00.gh-issue-150311.Xk9m3P.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
Fix three minor issues in ``configure.ac`` for the Cygwin port: use
consistent uppercase ``CYGWIN`` for ``ac_sys_system``, correct the static
library extension from ``.dll.a`` to ``.a`` when shared is disabled, and use
``$(CC)``/``$(CXX)`` instead of hardcoded ``gcc``/``g++``.
8 changes: 4 additions & 4 deletions configure
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 4 additions & 4 deletions configure.ac
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -334,7 +334,7 @@ then
ac_sys_system=Linux
;;
*-*-cygwin*)
ac_sys_system=Cygwin
ac_sys_system=CYGWIN
;;
*-apple-ios*)
ac_sys_system=iOS
Expand Down Expand Up @@ -1650,7 +1650,7 @@ else # shared is disabled
case $ac_sys_system in
CYGWIN*)
BLDLIBRARY='$(LIBRARY)'
LDLIBRARY='libpython$(LDVERSION).dll.a'
LDLIBRARY='libpython$(LDVERSION).a'
;;
esac
fi
Expand Down Expand Up @@ -3694,8 +3694,8 @@ then
dnl not implemented yet
]);;
CYGWIN*)
LDSHARED="gcc -shared -Wl,--enable-auto-image-base"
LDCXXSHARED="g++ -shared -Wl,--enable-auto-image-base";;
LDSHARED="$(CC) -shared -Wl,--enable-auto-image-base"
LDCXXSHARED="$(CXX) -shared -Wl,--enable-auto-image-base";;
*) LDSHARED="ld";;
esac
fi
Expand Down
Loading