gh-150311: Fix minor issues in configure.ac for the CYGWIN port#150328
Open
Ar-maan05 wants to merge 2 commits into
Open
gh-150311: Fix minor issues in configure.ac for the CYGWIN port#150328Ar-maan05 wants to merge 2 commits into
Ar-maan05 wants to merge 2 commits into
Conversation
- Use 'CYGWIN' (uppercase) for ac_sys_system to match the casing used
in all case-pattern references throughout configure.ac.
- Fix LDLIBRARY for static builds: use '.a' extension instead of
'.dll.a' when shared libraries are disabled.
- Replace hardcoded 'gcc' and 'g++' with '$(CC)' and '$(CXX)' in
LDSHARED/LDCXXSHARED for Cygwin.
|
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix three configure.ac issues for the Cygwin port.
ac_sys_system was set to Cygwin, but all case patterns in configure.ac match against CYGWIN*. Changed to CYGWIN for consistency.$(CC) and $ (CXX) to respect the user-configured compiler, consistent with other platforms such as UnixWare and SCO_SV.
When shared libraries are disabled, LDLIBRARY was incorrectly set to libpython$(LDVERSION).dll.a. The .dll.a extension is a DLL import library; changed to libpython$(LDVERSION).a for static builds.
LDSHARED and LDCXXSHARED in the CYGWIN* case were hardcoded to gcc and g++. Replaced with
gh-150311