gh-150318: Fix quantiles(method='exclusive') returning unsorted cut points for duplicate floats#150326
Open
edvilme wants to merge 2 commits into
Open
gh-150318: Fix quantiles(method='exclusive') returning unsorted cut points for duplicate floats#150326edvilme wants to merge 2 commits into
quantiles(method='exclusive') returning unsorted cut points for duplicate floats#150326edvilme wants to merge 2 commits into
Conversation
…rted cut points for duplicate floats When all data points are identical floats, the interpolation formula in the exclusive branch can produce results off by 1 ULP due to floating point rounding. Hence, adjacent cut points differ and the returned list violates the non-decreasing rule. This short-circuits the interpolation, returning the data value directly instead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When all data points are identical floats, the interpolation formula in the exclusive branch can produce results off by 1 ULP due to floating point rounding. Hence, adjacent cut points differ and the returned list violates the non-decreasing rule.
This short-circuits the interpolation, returning the data value directly instead.