From 42f07ac814593d5e5d8eb0dee1eb0afd64dbdfd7 Mon Sep 17 00:00:00 2001 From: Hansraj Das Date: Thu, 25 Jul 2019 01:10:38 +0530 Subject: [PATCH 1/2] Remove duplicate call to strip method * Strip method was already used at starting of the loop, no need to call again * Combined 2 if blocks as in both we need to continue --- Parser/pgen/token.py | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/Parser/pgen/token.py b/Parser/pgen/token.py index 008e241e175e7f..f4d930e2f23e9a 100644 --- a/Parser/pgen/token.py +++ b/Parser/pgen/token.py @@ -6,9 +6,7 @@ def generate_tokens(tokens): for line in tokens: line = line.strip() - if not line: - continue - if line.strip().startswith('#'): + if not line or line.startswith('#') continue name = line.split()[0] @@ -22,9 +20,7 @@ def generate_opmap(tokens): for line in tokens: line = line.strip() - if not line: - continue - if line.strip().startswith('#'): + if not line or line.startswith('#') continue pieces = line.split() From faac98fe7852453ee116d17996e6a35da5e313f0 Mon Sep 17 00:00:00 2001 From: Hansraj Das Date: Thu, 25 Jul 2019 01:18:29 +0530 Subject: [PATCH 2/2] Add colon at end of if condition --- Parser/pgen/token.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Parser/pgen/token.py b/Parser/pgen/token.py index f4d930e2f23e9a..e7e8f3f1b661e3 100644 --- a/Parser/pgen/token.py +++ b/Parser/pgen/token.py @@ -6,7 +6,7 @@ def generate_tokens(tokens): for line in tokens: line = line.strip() - if not line or line.startswith('#') + if not line or line.startswith('#'): continue name = line.split()[0] @@ -20,7 +20,7 @@ def generate_opmap(tokens): for line in tokens: line = line.strip() - if not line or line.startswith('#') + if not line or line.startswith('#'): continue pieces = line.split()