Skip to content

parser_generator.py typo - keywods -> keywords#135014

Merged
hugovk merged 2 commits into
python:mainfrom
chemelnucfin:patch-1
Jul 19, 2025
Merged

parser_generator.py typo - keywods -> keywords#135014
hugovk merged 2 commits into
python:mainfrom
chemelnucfin:patch-1

Conversation

@chemelnucfin

@chemelnucfin chemelnucfin commented Jun 2, 2025

Copy link
Copy Markdown
Contributor

Pull Request title

Trivial changes, like fixing a typo, do not need an issue.

Typo in comment

@python-cla-bot

python-cla-bot Bot commented Jun 2, 2025 •
edited
Loading

Copy link
Copy Markdown

All commit authors signed the Contributor License Agreement.

CLA signed

@bedevere-app

bedevere-app Bot commented Jun 2, 2025

Copy link
Copy Markdown

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

auvipy
auvipy approved these changes Jun 2, 2025
View reviewed changes

@auvipy auvipy left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

right work, but you also need to sign the cla and use skipnews

@bedevere-app

bedevere-app Bot commented Jun 2, 2025

Copy link
Copy Markdown

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

@chemelnucfin

chemelnucfin commented Jun 3, 2025

Copy link
Copy Markdown
Contributor Author

right work, but you also need to sign the cla and use skipnews

I believe skipnews should be added by maintainers? I signed the cla.

Should I keep updating the branch or can someone just merge this trivial PR? Thanks.

@johnzhou721

johnzhou721 commented Jun 3, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Need someone to apply skip news and skip issue. Merging main into the branch or rebasing on top of main doesn't do harm but is unnessacary.

*EDIT-- as long as there are no conflicts.

@hugovk hugovk added needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes labels Jul 19, 2025
@hugovk

hugovk commented Jul 19, 2025

Copy link
Copy Markdown
Member

Merging main is only needed if there's a conflict, or it's been a very long time and we want to check the CI still passes. Unnecessary merges uses up CI resources and pings those involved -- so this could be considered harm.

Anyway, thanks for the PR, let's merge!

@hugovk hugovk merged commit f520f22 into python:main Jul 19, 2025
56 checks passed
@miss-islington-app

miss-islington-app Bot commented Jul 19, 2025

Copy link
Copy Markdown

Thanks @chemelnucfin for the PR, and @hugovk for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 19, 2025
@chemelnucfin @miss-islington
parser_generator.py typo - keywods -> keywords (pythonGH-135014)
49368a8 
(cherry picked from commit f520f22)

Co-authored-by: chemelnucfin <3982092+chemelnucfin@users.noreply.github.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 19, 2025
@chemelnucfin @miss-islington
parser_generator.py typo - keywods -> keywords (pythonGH-135014)
2fefad0 
(cherry picked from commit f520f22)

Co-authored-by: chemelnucfin <3982092+chemelnucfin@users.noreply.github.com>
@bedevere-app

bedevere-app Bot commented Jul 19, 2025

Copy link
Copy Markdown

GH-136772 is a backport of this pull request to the 3.14 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.14 bugs and security fixes label Jul 19, 2025
@bedevere-app

bedevere-app Bot commented Jul 19, 2025

Copy link
Copy Markdown

GH-136773 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.13 bugs and security fixes label Jul 19, 2025
hugovk pushed a commit that referenced this pull request Jul 19, 2025
@miss-islington @chemelnucfin
[3.13] parser_generator.py typo - keywods -> keywords (GH-135014) (#1…
0936a53 
…36773)

Co-authored-by: chemelnucfin <3982092+chemelnucfin@users.noreply.github.com>
hugovk pushed a commit that referenced this pull request Jul 19, 2025
@miss-islington @chemelnucfin
[3.14] parser_generator.py typo - keywods -> keywords (GH-135014) (#1…
81aab6d 
…36772)

Co-authored-by: chemelnucfin <3982092+chemelnucfin@users.noreply.github.com>
omerpresler pushed a commit to omerpresler/cpython that referenced this pull request Jul 19, 2025
@chemelnucfin @omerpresler
parser_generator.py typo - keywods -> keywords (python#135014)
9a55104
omerpresler pushed a commit to omerpresler/cpython that referenced this pull request Jul 19, 2025
@chemelnucfin @omerpresler
parser_generator.py typo - keywods -> keywords (python#135014)
7357c42
@hugovk hugovk added the sprint label Jul 19, 2025
taegyunkim pushed a commit to taegyunkim/cpython that referenced this pull request Aug 4, 2025
@chemelnucfin @taegyunkim
parser_generator.py typo - keywods -> keywords (python#135014)
63d285d
Agent-Hellboy pushed a commit to Agent-Hellboy/cpython that referenced this pull request Aug 19, 2025
@chemelnucfin @Agent-Hellboy
parser_generator.py typo - keywods -> keywords (python#135014)
a3f7efb
kumaraditya303 pushed a commit to miss-islington/cpython that referenced this pull request Sep 9, 2025
@miss-islington @chemelnucfin @kumaraditya303
[3.14] parser_generator.py typo - keywods -> keywords (pythonGH-135014)…
9d6de59 
… (python#136772)

Co-authored-by: chemelnucfin <3982092+chemelnucfin@users.noreply.github.com>
@chemelnucfin chemelnucfin deleted the patch-1 branch September 21, 2025 03:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pablogsal pablogsal Awaiting requested review from pablogsal pablogsal is a code owner

@lysnikolaou lysnikolaou Awaiting requested review from lysnikolaou lysnikolaou is a code owner

3 more reviewers

@auvipy auvipy auvipy approved these changes

@Wulian233 Wulian233 Wulian233 approved these changes

@johnzhou721 johnzhou721 johnzhou721 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

skip issue skip news sprint topic-parser

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@chemelnucfin @johnzhou721 @hugovk @auvipy @Wulian233 @StanFromIreland