From 286a4a551a0d25580cbda5ebac9125c73bfca713 Mon Sep 17 00:00:00 2001 From: Zackery Spytz Date: Sun, 28 Apr 2019 06:18:26 -0600 Subject: [PATCH] bpo-36745: Fix a possible reference leak in PyObject_SetAttr() --- Objects/object.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/Objects/object.c b/Objects/object.c index e7ec7aec490f8b3..589bf365e870fdf 100644 --- a/Objects/object.c +++ b/Objects/object.c @@ -1044,8 +1044,10 @@ PyObject_SetAttr(PyObject *v, PyObject *name, PyObject *value) } if (tp->tp_setattr != NULL) { const char *name_str = PyUnicode_AsUTF8(name); - if (name_str == NULL) + if (name_str == NULL) { + Py_DECREF(name); return -1; + } err = (*tp->tp_setattr)(v, (char *)name_str, value); Py_DECREF(name); return err;