Skip to content

gh-128133: Added relaxed atomics to bytes_hash - #128412

Merged
kumaraditya303 merged 9 commits into
python:mainfrom
abhijeetsharma200:gh-128133-bytes_hash-atomics
Jan 3, 2025
Merged

gh-128133: Added relaxed atomics to bytes_hash#128412
kumaraditya303 merged 9 commits into
python:mainfrom
abhijeetsharma200:gh-128133-bytes_hash-atomics

Conversation

@abhijeetsharma200

@abhijeetsharma200 abhijeetsharma200 commented Jan 2, 2025 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Contributor

@ghost

ghost commented Jan 2, 2025 •
edited by ghost
Loading

Copy link
Copy Markdown

All commit authors signed the Contributor License Agreement.
CLA signed

@bedevere-app bedevere-app Bot mentioned this pull request Jan 2, 2025
Closed
@bedevere-app

bedevere-app Bot commented Jan 2, 2025

Copy link
Copy Markdown

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

@Eclips4
Eclips4 requested a review from colesbury January 2, 2025 13:08
Eclips4
Eclips4 reviewed Jan 2, 2025
View reviewed changes
Comment thread Objects/bytesobject.c
@bedevere-app

bedevere-app Bot commented Jan 2, 2025

Copy link
Copy Markdown

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

@bedevere-app

bedevere-app Bot commented Jan 2, 2025

Copy link
Copy Markdown

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

@bedevere-app

bedevere-app Bot commented Jan 2, 2025

Copy link
Copy Markdown

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

kumaraditya303
kumaraditya303 reviewed Jan 2, 2025
View reviewed changes
Comment thread Objects/bytesobject.c Outdated
ZeroIntensity
ZeroIntensity reviewed Jan 2, 2025
View reviewed changes
Comment thread Objects/bytesobject.c Outdated
Comment thread Objects/bytesobject.c Outdated
Comment thread Objects/bytesobject.c
@bedevere-app

bedevere-app Bot commented Jan 2, 2025

Copy link
Copy Markdown

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

kumaraditya303
kumaraditya303 reviewed Jan 2, 2025
View reviewed changes
Comment thread Objects/bytesobject.c Outdated
@kumaraditya303
kumaraditya303 merged commit 0706bab into python:main Jan 3, 2025
srinivasreddy pushed a commit to srinivasreddy/cpython that referenced this pull request Jan 8, 2025
@abhijeetsharma200 @srinivasreddy
pythongh-128133: use relaxed atomics for hash of bytes (python#128412)
6fa32e7
@ngoldbaum ngoldbaum mentioned this pull request Feb 11, 2025
Closed
@ngoldbaum

ngoldbaum commented Feb 11, 2025

Copy link
Copy Markdown
Contributor

@kumaraditya303 can this get a backport to 3.13? It looks like PyO3 reliably hits a race in the bytes hash on module import. PyO3/pyo3#4904 (comment)

@colesbury colesbury added the needs backport to 3.13 bugs and security fixes label Feb 11, 2025
@miss-islington-app

miss-islington-app Bot commented Feb 11, 2025

Copy link
Copy Markdown

Thanks @abhijeetsharma200 for the PR, and @kumaraditya303 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

@miss-islington-app

miss-islington-app Bot commented Feb 11, 2025

Copy link
Copy Markdown

Sorry, @abhijeetsharma200 and @kumaraditya303, I could not cleanly backport this to 3.13 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 0706bab1c0985761cdbc07ab448f98c717276b36 3.13

colesbury pushed a commit to colesbury/cpython that referenced this pull request Feb 11, 2025
@abhijeetsharma200 @colesbury
[3.13] pythongh-128133: use relaxed atomics for hash of bytes (python…
0ec5c63 
…GH-128412)

(cherry picked from commit 0706bab)

Co-authored-by: Abhijeet <abhijeetsharma2002@gmail.com>
@bedevere-app

bedevere-app Bot commented Feb 11, 2025

Copy link
Copy Markdown

GH-130022 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.13 bugs and security fixes label Feb 11, 2025
@colesbury colesbury mentioned this pull request Feb 11, 2025
Merged
Yhg1s pushed a commit that referenced this pull request Feb 12, 2025
@colesbury @abhijeetsharma200
[3.13] gh-128133: use relaxed atomics for hash of bytes (GH-128412) (#…
e4d0303 
…130022)

(cherry picked from commit 0706bab)

Co-authored-by: Abhijeet <abhijeetsharma2002@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ZeroIntensity ZeroIntensity ZeroIntensity left review comments
@Eclips4 Eclips4 Eclips4 left review comments
@kumaraditya303 kumaraditya303 kumaraditya303 approved these changes
@colesbury colesbury Awaiting requested review from colesbury

Assignees

@kumaraditya303 kumaraditya303

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@abhijeetsharma200 @ngoldbaum @colesbury @ZeroIntensity @kumaraditya303 @Eclips4