draft implementation of dict.with_values#12802
Closed
methane wants to merge 3 commits into
Closed
Conversation
eb62d7e to
0e67ddb
Compare
vstinner
reviewed
Apr 12, 2019
vstinner
left a comment
Member
There was a problem hiding this comment.
Tests are missing :-) I would help me to understand how it's supposed to be used.
981a913 to
bbb3e94
Compare
Member
|
Would you mind to open an associated issue to provide more context? I don't see the point of a private method, if it's not used. Maybe provide the link to your previous thread on the python-dev mailing list. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.