From ed8205246875cc5b54957014e3f566726911c967 Mon Sep 17 00:00:00 2001 From: AraHaan Date: Thu, 4 Jul 2024 17:49:00 -0400 Subject: [PATCH 1/4] Fixed an issue where building inside of a clone directory with spaces would result in not being able to build at all. This is an issue as some people have github repositories with spaces in name and has cpython as a submodule so they can test with the latest and greatest main branch and the feature branches (3.13, 3.12, etc) Having regen.targets use the " msbuild escape sequence for all input and output file paths ensures that this issue never happens again as long as the paths are wrapped in quotes. Also it's not acceptable to have to move the submodule out of the folder with a space nor is it acceptable to rename the folder that has a space sometimes. Using Quotes is a more acceptable solution to this. --- PCbuild/regen.targets | 20 ++++++++++---------- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/PCbuild/regen.targets b/PCbuild/regen.targets index 4aa14ed1fad9eb..ddc7e0d152b61f 100644 --- a/PCbuild/regen.targets +++ b/PCbuild/regen.targets @@ -82,7 +82,7 @@ - @@ -90,23 +90,23 @@ Inputs="@(_CasesSources)" Outputs="@(_CasesOutputs)" DependsOnTargets="FindPythonForBuild"> - - - - - - - - - From 4cdb83132bcf13f9cdf950b217ee8ab34f7d0378 Mon Sep 17 00:00:00 2001 From: AraHaan Date: Thu, 4 Jul 2024 18:14:07 -0400 Subject: [PATCH 2/4] Fixed a few more possible places of failure. --- PCbuild/regen.targets | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/PCbuild/regen.targets b/PCbuild/regen.targets index ddc7e0d152b61f..f333ae965af153 100644 --- a/PCbuild/regen.targets +++ b/PCbuild/regen.targets @@ -50,7 +50,7 @@ DependsOnTargets="FindPythonForBuild"> - @@ -58,7 +58,7 @@ Inputs="@(_ASTSources)" Outputs="@(_ASTOutputs)" DependsOnTargets="FindPythonForBuild"> - @@ -66,7 +66,7 @@ Inputs="@(_TokenSources)" Outputs="@(_TokenOutputs)" DependsOnTargets="FindPythonForBuild"> - From 27e0f3e62a3c17e06d9cb5ea8d6ff8eabfc4e7b8 Mon Sep 17 00:00:00 2001 From: AraHaan Date: Fri, 5 Jul 2024 11:32:52 -0400 Subject: [PATCH 3/4] Apply suggestions from code review --- PCbuild/regen.targets | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/PCbuild/regen.targets b/PCbuild/regen.targets index f333ae965af153..87eb1a4eaa4cf3 100644 --- a/PCbuild/regen.targets +++ b/PCbuild/regen.targets @@ -50,7 +50,7 @@ DependsOnTargets="FindPythonForBuild"> - @@ -58,7 +58,7 @@ Inputs="@(_ASTSources)" Outputs="@(_ASTOutputs)" DependsOnTargets="FindPythonForBuild"> - @@ -66,7 +66,7 @@ Inputs="@(_TokenSources)" Outputs="@(_TokenOutputs)" DependsOnTargets="FindPythonForBuild"> - @@ -82,7 +82,7 @@ - From 9d040a25c7f18e137cfabe0dd84dd89fd57254d3 Mon Sep 17 00:00:00 2001 From: AraHaan Date: Fri, 5 Jul 2024 11:45:29 -0400 Subject: [PATCH 4/4] Apply suggestions from code review --- PCbuild/regen.targets | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/PCbuild/regen.targets b/PCbuild/regen.targets index 87eb1a4eaa4cf3..416241d9d0df10 100644 --- a/PCbuild/regen.targets +++ b/PCbuild/regen.targets @@ -90,23 +90,23 @@ Inputs="@(_CasesSources)" Outputs="@(_CasesOutputs)" DependsOnTargets="FindPythonForBuild"> - - - - - - - - -