bpo-31506: Clarify error messages for object.__new__ and object.__init__#11641
Merged
Conversation
ncoghlan
approved these changes
Feb 19, 2019
ncoghlan
left a comment
Contributor
There was a problem hiding this comment.
LGTM, thanks. I'll tweak the NEWS entry and commit message, and then let Miss-Islington do the merge :)
Member
|
Please don't use automerge in PRs with multiple commits. It results in ugly commit messages containing all the history of intermediate changes. |
Contributor
|
Oh, I've been doing that wrong, then - I thought automerge did the squash commit and used the first message in the PR as the commit message :( |
Contributor
|
Thanks @CuriousLearner for the PR, and @ncoghlan for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7. |
|
GH-11939 is a backport of this pull request to the 3.7 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Feb 19, 2019
…t__ (pythonGH-11641) `object.__new__` and `object.__init__` do take one argument each, they just don't take extra user supplied arguments. Patch by Sanyam Khurana. (cherry picked from commit 5105483) Co-authored-by: Sanyam Khurana <8039608+CuriousLearner@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
object.__new__andobject.__init__do take one argument each,they just don't take extra user supplied arguments.
https://bugs.python.org/issue31506