Skip to content

bpo-35596: Fix vcruntime140.dll being added to embeddable distro multiple times.#11329

Merged
miss-islington merged 2 commits into
python:masterfrom
zooba:fix-double-vcruntime
Dec 27, 2018
Merged

bpo-35596: Fix vcruntime140.dll being added to embeddable distro multiple times.#11329
miss-islington merged 2 commits into
python:masterfrom
zooba:fix-double-vcruntime

Conversation

@zooba

@zooba zooba commented Dec 27, 2018

Copy link
Copy Markdown
Member

@miss-islington

Copy link
Copy Markdown
Contributor

@zooba: Status check is done, and it's a success ✅ .

@miss-islington miss-islington merged commit 59c2aa2 into python:master Dec 27, 2018
@miss-islington

Copy link
Copy Markdown
Contributor

Thanks @zooba for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

@zooba zooba deleted the fix-double-vcruntime branch December 27, 2018 20:44
@bedevere-bot

Copy link
Copy Markdown

GH-11331 is a backport of this pull request to the 3.7 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Dec 27, 2018
…iple times. (pythonGH-11329)

https://bugs.python.org/issue35596
(cherry picked from commit 59c2aa2)

Co-authored-by: Steve Dower <steve.dower@microsoft.com>
miss-islington added a commit that referenced this pull request Dec 28, 2018
…iple times. (GH-11329)

https://bugs.python.org/issue35596
(cherry picked from commit 59c2aa2)

Co-authored-by: Steve Dower <steve.dower@microsoft.com>
@bedevere-bot

Copy link
Copy Markdown

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot x86-64 High Sierra 3.7 has failed when building commit bbf6954.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/147/builds/581) and take a look at the build logs.
  4. Check if the failure is related to this commit (bbf6954) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/147/builds/581

Click to see traceback logs
Reset branch '3.7'

Configured with: --prefix=/Applications/Xcode.app/Contents/Developer/usr --with-gxx-include-dir=/usr/include/c++/4.2.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants