Repository navigation
Add support of KZ1048 (RK1048) encoding #66872
Description
| BPO | 22682 |
|---|---|
| Nosy | @malemburg, @loewis, @amauryfa, @serhiy-storchaka |
| Files |
Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.
Show more details
GitHub fields:
assignee = 'https://github.com/serhiy-storchaka'
closed_at = <Date 2015-05-12.20:28:05.184>
created_at = <Date 2014-10-20.20:21:16.695>
labels = ['type-feature', 'library']
title = 'Add support of KZ1048 (RK1048) encoding'
updated_at = <Date 2015-05-12.21:35:20.333>
user = 'https://github.com/serhiy-storchaka'bugs.python.org fields:
activity = <Date 2015-05-12.21:35:20.333>
actor = 'python-dev'
assignee = 'serhiy.storchaka'
closed = True
closed_date = <Date 2015-05-12.20:28:05.184>
closer = 'serhiy.storchaka'
components = ['Library (Lib)']
creation = <Date 2014-10-20.20:21:16.695>
creator = 'serhiy.storchaka'
dependencies = []
files = ['36984']
hgrepos = []
issue_num = 22682
keywords = ['patch']
message_count = 9.0
messages = ['229741', '230266', '242963', '242977', '242986', '242989', '243007', '243009', '243019']
nosy_count = 5.0
nosy_names = ['lemburg', 'loewis', 'amaury.forgeotdarc', 'python-dev', 'serhiy.storchaka']
pr_nums = []
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'enhancement'
url = 'https://bugs.python.org/issue22682'
versions = ['Python 3.5']
Activity
serhiy-storchaka commentedon Oct 20, 2014
KZ1048 is Kazakh encoding based on CP1251 (Windows Cyrillic codepage). It is standardized by Unicode [1] and IANA [2]. It is also known as STRK1048-2002 (by the name of original Kazakh standard) and RK1048 (used in glibc). It is default encoding of Kazakh locale kk_KZ in glibc.
Proposed patch adds support for this encoding.
[1] ftp://ftp.unicode.org/Public/MAPPINGS/VENDORS/MISC/KZ1048.TXT
[2] https://www.iana.org/assignments/charset-reg/KZ-1048
amauryfa commentedon Oct 30, 2014
Looks good to me.
I checked that there are only 16 differences between cp1251 and kz1048,
and that the two standards define the same mapping.
serhiy-storchaka commentedon May 12, 2015
Ping.
amauryfa commentedon May 12, 2015
Please go ahead! Or do you expect someone else to review the patch?
serhiy-storchaka commentedon May 12, 2015
It would be nice if somebody of the encoding package maintainers (Martin, Marc-Andre) will approve (or reject) the patch.
malemburg commentedon May 12, 2015
Looks good. Thanks, Serhiy.
python-dev commentedon May 12, 2015
New changeset 6e1fe5bfba48 by Serhiy Storchaka in branch 'default':
Issue bpo-22682: Added support for the kz1048 encoding.
https://hg.python.org/cpython/rev/6e1fe5bfba48
serhiy-storchaka commentedon May 12, 2015
Thank you for your reviews Amaury and Marc-Andre.
python-dev commentedon May 12, 2015
New changeset def3bab79c8f by Serhiy Storchaka in branch 'default':
Added forgotten new files for issues bpo-22681 and bpo-22682.
https://hg.python.org/cpython/rev/def3bab79c8f