You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In order to get the build to proceed, you can change line
210 of setup.py from:
exceptImportError, why:
to:
except (ImportError, RuntimeError), why:
This is just before:
self.announce('*** WARNING: renaming "%s" since
importing it' ...)
nnorwitz commented on Feb 23, 2003
nnorwitzmannequin
Mannequin
More actions
Logged In: YES
user_id=33168
Guido, I agree with your comment on python-dev that the fix
below is not best. Attached is a patch which catches all
exceptions, and changes the warning message appropriately.
There are 2 other issues.
I don't know why the if 1: is there, should that be removed?
During a normal build these warning messages aren't
printed, shouldn't they be?
I think the renaming shouldn't happen at all unless the
exception is ImportError.
The if 1 can then be replaced by if isinstance(why,
ImportError).
The message in the else branch should be changed to
include the exception name.
I thought I fixed the logging level of these messages, by
adding "level=3", in one of the first checkins after
releasing 2.3a2. But possibly I may have botched that. Can
you check that they really aren't printed?
(Note, there are other compilation errors in the attached logs.)
nnorwitz commented on Feb 28, 2003
nnorwitzmannequin
Mannequin
More actions
Logged In: YES
user_id=33168
Updated patch for review (updated patch 2). Guido, can you
review (it's short)?
renaming only happens on ImportError
if 1 is removed in favor of checking for ImportError
there was no problem with the warning being printed
(level is in there), I must have been daydreaming.
I reverted the change in iconv to again raise a RuntimeError
instead of ImportError. The make will continue with the
warning printed. This will hopefully get us over the worst
problems with iconv.
Activity
rwgk commentedon Feb 20, 2003
Using the latest Python 2.3a2 release
./configure; make
fails on this platform:
IRIX rattler 6.5 10120734 IP32
See attached logs.
I've also tried configure --disable-ipv6, but the result is
the same.
The previous 2.3a1 release works without a problem
on the exact same machine.
nnorwitz commentedon Feb 20, 2003
Logged In: YES
user_id=33168
In order to get the build to proceed, you can change line
210 of setup.py from:
This is just before:
self.announce('*** WARNING: renaming "%s" since
importing it' ...)
nnorwitz commentedon Feb 23, 2003
Logged In: YES
user_id=33168
Guido, I agree with your comment on python-dev that the fix
below is not best. Attached is a patch which catches all
exceptions, and changes the warning message appropriately.
There are 2 other issues.
printed, shouldn't they be?
gvanrossum commentedon Feb 23, 2003
Logged In: YES
user_id=6380
I think the renaming shouldn't happen at all unless the
exception is ImportError.
The if 1 can then be replaced by if isinstance(why,
ImportError).
The message in the else branch should be changed to
include the exception name.
I thought I fixed the logging level of these messages, by
adding "level=3", in one of the first checkins after
releasing 2.3a2. But possibly I may have botched that. Can
you check that they really aren't printed?
gvanrossum commentedon Feb 24, 2003
Logged In: YES
user_id=6380
(Note, there are other compilation errors in the attached logs.)
nnorwitz commentedon Feb 28, 2003
Logged In: YES
user_id=33168
Updated patch for review (updated patch 2). Guido, can you
review (it's short)?
(level is in there), I must have been daydreaming.
I reverted the change in iconv to again raise a RuntimeError
instead of ImportError. The make will continue with the
warning printed. This will hopefully get us over the worst
problems with iconv.
gvanrossum commentedon Feb 28, 2003
Logged In: YES
user_id=6380
Yes, looks good.
nnorwitz commentedon Feb 28, 2003
Logged In: YES
user_id=33168
Checked in as:
setup.py 1.152
Modules/_iconv_codec.c 1.14Misc/NEWS 1.681
nnorwitz commentedon Feb 28, 2003
Logged In: YES
user_id=33168
Ralf, could you test from CVS to make sure everything is ok.
The fix was general, but I'd like to make sure beta1 is in
better shape. Thanks.