Serhiy's feedback

FFY00 · FFY00 · commit e30c9d89237b · 2021-09-15T13:02:58.000+01:00
Signed-off-by: Filipe Laíns &lt;lains@riseup.net&gt;
diff --git a/Doc/library/contextlib.rst b/Doc/library/contextlib.rst
@@ -355,7 +355,12 @@ Functions and classes provided:
 
 .. function:: chdir(path)
 
-   Non thread-safe context manager to change the current working directory.
+   Non parallel-safe context manager to change the current working directory.
+   As this changes a global state, the working directory, it is not suitable
+   for use in most threaded or aync contexts. It is also not suitable for most
+   non-linear code execution, like generators, where the program execution is
+   temporarily relinquished -- unless explicitely desired, you should not yield
+   when this context manager is active.
 
    This is a simple wrapper around :func:`~os.chdir`, it changes the current
    working directory upon entering and restores the old one on exit.
diff --git a/Lib/test/test_contextlib.py b/Lib/test/test_contextlib.py
@@ -1086,41 +1086,41 @@ class TestChdir(unittest.TestCase):
     def test_simple(self):
         old_cwd = os.getcwd()
         target = os.path.join(os.path.dirname(__file__), 'data')
-        assert old_cwd != target
+        self.assertNotEqual(old_cwd, target)
 
         with chdir(target):
-            assert os.getcwd() == target
-        assert os.getcwd() == old_cwd
+            self.assertEqual(os.getcwd(), target)
+        self.assertEqual(os.getcwd(), old_cwd)
 
     def test_reentrant(self):
         old_cwd = os.getcwd()
         target1 = os.path.join(os.path.dirname(__file__), 'data')
         target2 = os.path.join(os.path.dirname(__file__), 'ziptestdata')
-        assert old_cwd not in (target1, target2)
+        self.assertNotIn(old_cwd, (target1, target2))
         chdir1, chdir2 = chdir(target1), chdir(target2)
 
         with chdir1:
-            assert os.getcwd() == target1
+            self.assertEqual(os.getcwd(), target1)
             with chdir2:
-                assert os.getcwd() == target2
+                self.assertEqual(os.getcwd(), target2)
                 with chdir1:
-                    assert os.getcwd() == target1
-                assert os.getcwd() == target2
-            assert os.getcwd() == target1
-        assert os.getcwd() == old_cwd
+                    self.assertEqual(os.getcwd(), target1)
+                self.assertEqual(os.getcwd(), target2)
+            self.assertEqual(os.getcwd(), target1)
+        self.assertEqual(os.getcwd(), old_cwd)
 
     def test_exception(self):
         old_cwd = os.getcwd()
         target = os.path.join(os.path.dirname(__file__), 'data')
-        assert old_cwd != target
+        self.assertNotEqual(old_cwd, target)
 
         try:
             with chdir(target):
-                assert os.getcwd() == target
+                self.assertEqual(os.getcwd(), target)
                 raise RuntimeError("boom")
         except RuntimeError as re:
-            assert str(re) == "boom"
-        assert os.getcwd() == old_cwd
+            self.assertEqual(str(re), "boom")
+        self.assertEqual(os.getcwd(), old_cwd)
 
 
 if __name__ == "__main__":
