Simplify code in warnings modules (#1957)

alex · web-flow · commit e14af32cc656 · 2017-06-05T09:13:50.000-04:00
Metaprogramming a list of attributes was excessive, and made the code less readable and slower. Backport of 5de3a64
diff --git a/Lib/warnings.py b/Lib/warnings.py
@@ -309,9 +309,12 @@ class WarningMessage(object):
 
     def __init__(self, message, category, filename, lineno, file=None,
                     line=None):
-        local_values = locals()
-        for attr in self._WARNING_DETAILS:
-            setattr(self, attr, local_values[attr])
+        self.message = message
+        self.category = category
+        self.filename = filename
+        self.lineno = lineno
+        self.file = file
+        self.line = line
         self._category_name = category.__name__ if category else None
 
     def __str__(self):
