Issue #23700: NamedTemporaryFile iterator closed underlied file object in

serhiy-storchaka · serhiy-storchaka · commit d83b7c2df443 · 2015-03-20T16:11:20.000+02:00
some circunstances while NamedTemporaryFile object was living.  This causes
failing test_csv.  Changed the implementation of NamedTemporaryFile.__iter__
to make tests passed.
diff --git a/Lib/tempfile.py b/Lib/tempfile.py
@@ -426,9 +426,11 @@ def close(self):
 
     # iter() doesn't use __getattr__ to find the __iter__ method
     def __iter__(self):
-        # don't return iter(self.file), but yield from it to avoid closing
-        # file as long as it's being used as iterator, see issue #23000
-        yield from iter(self.file)
+        # Don't return iter(self.file), but yield from it to avoid closing
+        # file as long as it's being used as iterator, see issue #23000.
+        # XXX Also don't use "yield from"!
+        for line in self.file:
+            yield line
 
 
 def NamedTemporaryFile(mode='w+b', buffering=-1, encoding=None,
