fix resource warnings in test_sax #10269

benjaminp · benjaminp · commit d5df36d37805 · 2010-10-31T18:23:23.000Z
diff --git a/Lib/test/test_sax.py b/Lib/test/test_sax.py
@@ -463,7 +463,8 @@ def test_filter_basic(self):
 #
 # ===========================================================================
 
-xml_test_out = open(TEST_XMLFILE_OUT).read()
+with open(TEST_XMLFILE_OUT) as f:
+    xml_test_out = f.read()
 
 class ExpatReaderTest(XmlTestBase):
 
@@ -475,7 +476,8 @@ def test_expat_file(self):
         xmlgen = XMLGenerator(result)
 
         parser.setContentHandler(xmlgen)
-        parser.parse(open(TEST_XMLFILE))
+        with open(TEST_XMLFILE) as f:
+            parser.parse(f)
 
         self.assertEquals(result.getvalue(), xml_test_out)
 
@@ -625,8 +627,9 @@ def test_expat_inpsource_stream(self):
 
         parser.setContentHandler(xmlgen)
         inpsrc = InputSource()
-        inpsrc.setByteStream(open(TEST_XMLFILE))
-        parser.parse(inpsrc)
+        with open(TEST_XMLFILE) as f:
+            inpsrc.setByteStream(f)
+            parser.parse(inpsrc)
 
         self.assertEquals(result.getvalue(), xml_test_out)
 
