Make PyXXX_Fini() functions private (GH-15531)

vstinner · web-flow · commit bed4817d52d7 · 2019-08-27T00:12:32.000+02:00
For example, rename PyTuple_Fini() to _PyTuple_Fini().

These functions are only declared in the internal C API.
diff --git a/Include/internal/pycore_pylifecycle.h b/Include/internal/pycore_pylifecycle.h
@@ -62,18 +62,19 @@ extern PyStatus _PyImportZip_Init(PyThreadState *tstate);
 
 /* Various internal finalizers */
 
-extern void PyMethod_Fini(void);
-extern void PyFrame_Fini(void);
-extern void PyCFunction_Fini(void);
-extern void PyDict_Fini(void);
-extern void PyTuple_Fini(void);
-extern void PyList_Fini(void);
-extern void PySet_Fini(void);
-extern void PyBytes_Fini(void);
-extern void PyFloat_Fini(void);
+extern void _PyMethod_Fini(void);
+extern void _PyFrame_Fini(void);
+extern void _PyCFunction_Fini(void);
+extern void _PyDict_Fini(void);
+extern void _PyTuple_Fini(void);
+extern void _PyList_Fini(void);
+extern void _PySet_Fini(void);
+extern void _PyBytes_Fini(void);
+extern void _PyFloat_Fini(void);
+extern void _PySlice_Fini(void);
+extern void _PyAsyncGen_Fini(void);
+
 extern void PyOS_FiniInterrupts(void);
-extern void PySlice_Fini(void);
-extern void PyAsyncGen_Fini(void);
 
 extern void _PyExc_Fini(void);
 extern void _PyImport_Fini(void);
@@ -82,7 +83,7 @@ extern void _PyGC_Fini(_PyRuntimeState *runtime);
 extern void _PyType_Fini(void);
 extern void _Py_HashRandomization_Fini(void);
 extern void _PyUnicode_Fini(void);
-extern void PyLong_Fini(void);
+extern void _PyLong_Fini(void);
 extern void _PyFaulthandler_Fini(void);
 extern void _PyHash_Fini(void);
 extern int _PyTraceMalloc_Fini(void);
diff --git a/Objects/bytesobject.c b/Objects/bytesobject.c
@@ -3047,7 +3047,7 @@ _PyBytes_Resize(PyObject **pv, Py_ssize_t newsize)
 }
 
 void
-PyBytes_Fini(void)
+_PyBytes_Fini(void)
 {
     int i;
     for (i = 0; i < UCHAR_MAX + 1; i++)
diff --git a/Objects/classobject.c b/Objects/classobject.c
@@ -375,7 +375,7 @@ PyMethod_ClearFreeList(void)
 }
 
 void
-PyMethod_Fini(void)
+_PyMethod_Fini(void)
 {
     (void)PyMethod_ClearFreeList();
 }
diff --git a/Objects/dictobject.c b/Objects/dictobject.c
@@ -282,7 +282,7 @@ _PyDict_DebugMallocStats(FILE *out)
 
 
 void
-PyDict_Fini(void)
+_PyDict_Fini(void)
 {
     PyDict_ClearFreeList();
 }
diff --git a/Objects/floatobject.c b/Objects/floatobject.c
@@ -2031,7 +2031,7 @@ PyFloat_ClearFreeList(void)
 }
 
 void
-PyFloat_Fini(void)
+_PyFloat_Fini(void)
 {
     (void)PyFloat_ClearFreeList();
 }
diff --git a/Objects/frameobject.c b/Objects/frameobject.c
@@ -997,7 +997,7 @@ PyFrame_ClearFreeList(void)
 }
 
 void
-PyFrame_Fini(void)
+_PyFrame_Fini(void)
 {
     (void)PyFrame_ClearFreeList();
 }
diff --git a/Objects/genobject.c b/Objects/genobject.c
@@ -1463,7 +1463,7 @@ PyAsyncGen_ClearFreeLists(void)
 }
 
 void
-PyAsyncGen_Fini(void)
+_PyAsyncGen_Fini(void)
 {
     PyAsyncGen_ClearFreeLists();
 }
diff --git a/Objects/listobject.c b/Objects/listobject.c
@@ -138,7 +138,7 @@ PyList_ClearFreeList(void)
 }
 
 void
-PyList_Fini(void)
+_PyList_Fini(void)
 {
     PyList_ClearFreeList();
 }
diff --git a/Objects/longobject.c b/Objects/longobject.c
@@ -5869,7 +5869,7 @@ _PyLong_Init(void)
 }
 
 void
-PyLong_Fini(void)
+_PyLong_Fini(void)
 {
     /* Integers are currently statically allocated. Py_DECREF is not
        needed, but Python must forget about the reference or multiple
diff --git a/Objects/methodobject.c b/Objects/methodobject.c
@@ -319,7 +319,7 @@ PyCFunction_ClearFreeList(void)
 }
 
 void
-PyCFunction_Fini(void)
+_PyCFunction_Fini(void)
 {
     (void)PyCFunction_ClearFreeList();
 }
diff --git a/Objects/setobject.c b/Objects/setobject.c
@@ -2318,7 +2318,7 @@ PySet_ClearFreeList(void)
 }
 
 void
-PySet_Fini(void)
+_PySet_Fini(void)
 {
     Py_CLEAR(emptyfrozenset);
 }
diff --git a/Objects/sliceobject.c b/Objects/sliceobject.c
@@ -100,7 +100,8 @@ PyObject _Py_EllipsisObject = {
  * created and then deleted again
  */
 static PySliceObject *slice_cache = NULL;
-void PySlice_Fini(void)
+
+void _PySlice_Fini(void)
 {
     PySliceObject *obj = slice_cache;
     if (obj != NULL) {
diff --git a/Objects/tupleobject.c b/Objects/tupleobject.c
@@ -989,7 +989,7 @@ PyTuple_ClearFreeList(void)
 }
 
 void
-PyTuple_Fini(void)
+_PyTuple_Fini(void)
 {
 #if PyTuple_MAXSAVESIZE > 0
     /* empty tuples are used all over the place and applications may
diff --git a/Python/pylifecycle.c b/Python/pylifecycle.c
@@ -1307,22 +1307,22 @@ Py_FinalizeEx(void)
     _PyExc_Fini();
 
     /* Sundry finalizers */
-    PyMethod_Fini();
-    PyFrame_Fini();
-    PyCFunction_Fini();
-    PyTuple_Fini();
-    PyList_Fini();
-    PySet_Fini();
-    PyBytes_Fini();
-    PyLong_Fini();
-    PyFloat_Fini();
-    PyDict_Fini();
-    PySlice_Fini();
+    _PyMethod_Fini();
+    _PyFrame_Fini();
+    _PyCFunction_Fini();
+    _PyTuple_Fini();
+    _PyList_Fini();
+    _PySet_Fini();
+    _PyBytes_Fini();
+    _PyLong_Fini();
+    _PyFloat_Fini();
+    _PyDict_Fini();
+    _PySlice_Fini();
     _PyGC_Fini(runtime);
     _PyWarnings_Fini(interp);
     _Py_HashRandomization_Fini();
     _PyArg_Fini();
-    PyAsyncGen_Fini();
+    _PyAsyncGen_Fini();
     _PyContext_Fini();
 
     /* Cleanup Unicode implementation */

Original file line number	Diff line number	Diff line change
`@@ -3047,7 +3047,7 @@ _PyBytes_Resize(PyObject **pv, Py_ssize_t newsize)`
`3047`	`3047`	`}`
`3048`	`3048`
`3049`	`3049`	`void`
`3050`		`-PyBytes_Fini(void)`
	`3050`	`+_PyBytes_Fini(void)`
`3051`	`3051`	`{`
`3052`	`3052`	`int i;`
`3053`	`3053`	`for (i = 0; i < UCHAR_MAX + 1; i++)`
Original file line number	Diff line number	Diff line change
`@@ -375,7 +375,7 @@ PyMethod_ClearFreeList(void)`
`375`	`375`	`}`
`376`	`376`
`377`	`377`	`void`
`378`		`-PyMethod_Fini(void)`
	`378`	`+_PyMethod_Fini(void)`
`379`	`379`	`{`
`380`	`380`	`(void)PyMethod_ClearFreeList();`
`381`	`381`	`}`
Original file line number	Diff line number	Diff line change
`@@ -282,7 +282,7 @@ _PyDict_DebugMallocStats(FILE *out)`
`282`	`282`
`283`	`283`
`284`	`284`	`void`
`285`		`-PyDict_Fini(void)`
	`285`	`+_PyDict_Fini(void)`
`286`	`286`	`{`
`287`	`287`	`PyDict_ClearFreeList();`
`288`	`288`	`}`
Original file line number	Diff line number	Diff line change
`@@ -2031,7 +2031,7 @@ PyFloat_ClearFreeList(void)`
`2031`	`2031`	`}`
`2032`	`2032`
`2033`	`2033`	`void`
`2034`		`-PyFloat_Fini(void)`
	`2034`	`+_PyFloat_Fini(void)`
`2035`	`2035`	`{`
`2036`	`2036`	`(void)PyFloat_ClearFreeList();`
`2037`	`2037`	`}`
Original file line number	Diff line number	Diff line change
`@@ -997,7 +997,7 @@ PyFrame_ClearFreeList(void)`
`997`	`997`	`}`
`998`	`998`
`999`	`999`	`void`
`1000`		`-PyFrame_Fini(void)`
	`1000`	`+_PyFrame_Fini(void)`
`1001`	`1001`	`{`
`1002`	`1002`	`(void)PyFrame_ClearFreeList();`
`1003`	`1003`	`}`
Original file line number	Diff line number	Diff line change
`@@ -1463,7 +1463,7 @@ PyAsyncGen_ClearFreeLists(void)`
`1463`	`1463`	`}`
`1464`	`1464`
`1465`	`1465`	`void`
`1466`		`-PyAsyncGen_Fini(void)`
	`1466`	`+_PyAsyncGen_Fini(void)`
`1467`	`1467`	`{`
`1468`	`1468`	`PyAsyncGen_ClearFreeLists();`
`1469`	`1469`	`}`
Original file line number	Diff line number	Diff line change
`@@ -138,7 +138,7 @@ PyList_ClearFreeList(void)`
`138`	`138`	`}`
`139`	`139`
`140`	`140`	`void`
`141`		`-PyList_Fini(void)`
	`141`	`+_PyList_Fini(void)`
`142`	`142`	`{`
`143`	`143`	`PyList_ClearFreeList();`
`144`	`144`	`}`
Original file line number	Diff line number	Diff line change
`@@ -5869,7 +5869,7 @@ _PyLong_Init(void)`
`5869`	`5869`	`}`
`5870`	`5870`
`5871`	`5871`	`void`
`5872`		`-PyLong_Fini(void)`
	`5872`	`+_PyLong_Fini(void)`
`5873`	`5873`	`{`
`5874`	`5874`	`/* Integers are currently statically allocated. Py_DECREF is not`
`5875`	`5875`	`needed, but Python must forget about the reference or multiple`
Original file line number	Diff line number	Diff line change
`@@ -319,7 +319,7 @@ PyCFunction_ClearFreeList(void)`
`319`	`319`	`}`
`320`	`320`
`321`	`321`	`void`
`322`		`-PyCFunction_Fini(void)`
	`322`	`+_PyCFunction_Fini(void)`
`323`	`323`	`{`
`324`	`324`	`(void)PyCFunction_ClearFreeList();`
`325`	`325`	`}`