Issue #14687: Avoid an useless duplicated string in PyUnicode_Format()

vstinner · vstinner · commit b80e46eca4a8 · 2012-04-30T05:21:52.000+02:00
diff --git a/Objects/unicodeobject.c b/Objects/unicodeobject.c
@@ -14051,20 +14051,16 @@ PyUnicode_Format(PyObject *format, PyObject *args)
                 }
             }
             /* Copy all characters, preserving len */
-            if (temp != NULL) {
-                assert(pbuf == PyUnicode_DATA(temp));
-                v = PyUnicode_Substring(temp, pindex, pindex + len);
+            if (pindex == 0 && len == PyUnicode_GET_LENGTH(temp)) {
+                r = _PyAccu_Accumulate(&acc, temp);
             }
             else {
-                const char *p = (const char *) pbuf;
-                assert(pbuf != NULL);
-                p += kind * pindex;
-                v = PyUnicode_FromKindAndData(kind, p, len);
+                v = PyUnicode_Substring(temp, pindex, pindex + len);
+                if (v == NULL)
+                    goto onError;
+                r = _PyAccu_Accumulate(&acc, v);
+                Py_DECREF(v);
             }
-            if (v == NULL)
-                goto onError;
-            r = _PyAccu_Accumulate(&acc, v);
-            Py_DECREF(v);
             if (r)
                 goto onError;
             if (width > len && repeat_accumulate(&acc, blank, width - len))
