Drop confusing commented out code in pystrtod.c (GH-6072) (GH-9586)

vstinner · web-flow · commit b54fc15e32a9 · 2018-09-26T07:45:19.000-07:00
Fix the following warning: Python/pystrtod.c: In function 'format_float_short': Python/pystrtod.c:1007:13: warning: 'strncpy' output truncated before terminating nul copying 3 bytes from a string of the same length [-Wstringop-truncation] strncpy(p, "ERR", 3); (cherry picked from commit 9fb8415)
diff --git a/Python/pystrtod.c b/Python/pystrtod.c
@@ -1062,8 +1062,6 @@ format_float_short(double d, char format_code,
         else {
             /* shouldn't get here: Gay's code should always return
                something starting with a digit, an 'I',  or 'N' */
-            strncpy(p, "ERR", 3);
-            /* p += 3; */
             Py_UNREACHABLE();
         }
         goto exit;

Original file line number	Diff line number	Diff line change
`@@ -1062,8 +1062,6 @@ format_float_short(double d, char format_code,`
`1062`	`1062`	`else {`
`1063`	`1063`	`/* shouldn't get here: Gay's code should always return`
`1064`	`1064`	`something starting with a digit, an 'I', or 'N' */`
`1065`		`- strncpy(p, "ERR", 3);`
`1066`		`- /* p += 3; */`
`1067`	`1065`	`Py_UNREACHABLE();`
`1068`	`1066`	`}`
`1069`	`1067`	`goto exit;`