A stray JUMP_BACKWARD also ends the trace

gvanrossum · gvanrossum · commit 8c750935aebd · 2023-07-06T16:51:27.000-07:00
diff --git a/Python/optimizer.c b/Python/optimizer.c
@@ -453,9 +453,11 @@ translate_bytecode_to_trace(
                     && trace_length + 3 <= max_length)
                 {
                     ADD_TO_TRACE(JUMP_TO_TOP, 0);
-                    goto done;
                 }
-                // Else fall through!
+                else {
+                    DPRINTF(2, "JUMP_BACKWARD not to top ends trace\n");
+                }
+                goto done;
             }
             default:
             {

Original file line number	Diff line number	Diff line change
`@@ -453,9 +453,11 @@ translate_bytecode_to_trace(`
`453`	`453`	`&& trace_length + 3 <= max_length)`
`454`	`454`	`{`
`455`	`455`	`ADD_TO_TRACE(JUMP_TO_TOP, 0);`
`456`		`- goto done;`
`457`	`456`	`}`
`458`		`- // Else fall through!`
	`457`	`+ else {`
	`458`	`+ DPRINTF(2, "JUMP_BACKWARD not to top ends trace\n");`
	`459`	`+ }`
	`460`	`+ goto done;`
`459`	`461`	`}`
`460`	`462`	`default:`
`461`	`463`	`{`