closes bpo-34474: Python/bltinmodule.c: Add missing NULL check in builtin_sum_impl() (GH-8872)

miss-islington · Alexey Izbyshev · web-flow · commit 7d470f3f24d0 · 2018-08-24T01:10:58.000-04:00
Reported by Svace static analyzer. (cherry picked from commit 2b824b2) Co-authored-by: Alexey Izbyshev <izbyshev@ispras.ru>
diff --git a/Python/bltinmodule.c b/Python/bltinmodule.c
@@ -2343,6 +2343,11 @@ builtin_sum_impl(PyObject *module, PyObject *iterable, PyObject *start)
                 }
             }
             result = PyFloat_FromDouble(f_result);
+            if (result == NULL) {
+                Py_DECREF(item);
+                Py_DECREF(iter);
+                return NULL;
+            }
             temp = PyNumber_Add(result, item);
             Py_DECREF(result);
             Py_DECREF(item);

Original file line number	Diff line number	Diff line change
`@@ -2343,6 +2343,11 @@ builtin_sum_impl(PyObject module, PyObject iterable, PyObject *start)`
`2343`	`2343`	`}`
`2344`	`2344`	`}`
`2345`	`2345`	`result = PyFloat_FromDouble(f_result);`
	`2346`	`+ if (result == NULL) {`
	`2347`	`+ Py_DECREF(item);`
	`2348`	`+ Py_DECREF(iter);`
	`2349`	`+ return NULL;`
	`2350`	`+ }`
`2346`	`2351`	`temp = PyNumber_Add(result, item);`
`2347`	`2352`	`Py_DECREF(result);`
`2348`	`2353`	`Py_DECREF(item);`