Issue #16704: Get rid of select.error in stdlib. Use OSError instead.

asvetlov · asvetlov · commit 6d8a122b9c0f · 2012-12-17T22:23:46.000+02:00
diff --git a/Lib/subprocess.py b/Lib/subprocess.py
@@ -1614,7 +1614,7 @@ def close_unregister_and_remove(fd):
                     raise TimeoutExpired(self.args, orig_timeout)
                 try:
                     ready = poller.poll(timeout)
-                except select.error as e:
+                except OSError as e:
                     if e.args[0] == errno.EINTR:
                         continue
                     raise
@@ -1682,7 +1682,7 @@ def _communicate_with_select(self, input, endtime, orig_timeout):
                     (rlist, wlist, xlist) = \
                         select.select(self._read_set, self._write_set, [],
                                       timeout)
-                except select.error as e:
+                except OSError as e:
                     if e.args[0] == errno.EINTR:
                         continue
                     raise
diff --git a/Lib/telnetlib.py b/Lib/telnetlib.py
@@ -313,7 +313,7 @@ def _read_until_with_poll(self, match, timeout):
             while i < 0 and not self.eof:
                 try:
                     ready = poller.poll(call_timeout)
-                except select.error as e:
+                except OSError as e:
                     if e.errno == errno.EINTR:
                         if timeout is not None:
                             elapsed = time() - time_start
@@ -683,7 +683,7 @@ def _expect_with_poll(self, expect_list, timeout=None):
             while not m and not self.eof:
                 try:
                     ready = poller.poll(call_timeout)
-                except select.error as e:
+                except OSError as e:
                     if e.errno == errno.EINTR:
                         if timeout is not None:
                             elapsed = time() - time_start
diff --git a/Lib/test/test_logging.py b/Lib/test/test_logging.py
@@ -773,7 +773,7 @@ def serve_forever(self, poll_interval):
             """
             try:
                 asyncore.loop(poll_interval, map=self.sockmap)
-            except select.error:
+            except OSError:
                 # On FreeBSD 8, closing the server repeatably
                 # raises this error. We swallow it if the
                 # server has been closed.
diff --git a/Lib/test/test_select.py b/Lib/test/test_select.py
@@ -32,7 +32,7 @@ def test_errno(self):
             fp.close()
             try:
                 select.select([fd], [], [], 0)
-            except select.error as err:
+            except OSError as err:
                 self.assertEqual(err.errno, errno.EBADF)
             else:
                 self.fail("exception not raised")
diff --git a/Lib/test/test_signal.py b/Lib/test/test_signal.py
@@ -299,10 +299,10 @@ def test_wakeup_fd_during(self):
             # We attempt to get a signal during the select call
             try:
                 select.select([read], [], [], TIMEOUT_FULL)
-            except select.error:
+            except OSError:
                 pass
             else:
-                raise Exception("select.error not raised")
+                raise Exception("OSError not raised")
             after_time = time.time()
             dt = after_time - before_time
             if dt >= TIMEOUT_HALF:
