Make sure that WeakValueDictionary[] raises KeyError instead of TypeError

freddrake · freddrake · commit 4fd06e0170aa · 2001-08-03T04:11:27.000Z
for keys that are not in the dictionary.
diff --git a/Lib/test/test_weakref.py b/Lib/test/test_weakref.py
@@ -252,6 +252,11 @@ def test_weak_values(self):
         del objects, o
         self.assert_(len(dict) == 0,
                      "deleting the values did not clear the dictionary")
+        # regression on SF bug #447152:
+        dict = weakref.WeakValueDictionary()
+        self.assertRaises(KeyError, dict.__getitem__, 1)
+        dict[2] = C()
+        self.assertRaises(KeyError, dict.__getitem__, 2)
 
     def test_weak_keys(self):
         #
diff --git a/Lib/weakref.py b/Lib/weakref.py
@@ -41,7 +41,7 @@ class WeakValueDictionary(UserDict.UserDict):
     # way in).
 
     def __getitem__(self, key):
-        o = self.data.get(key)()
+        o = self.data[key]()
         if o is None:
             raise KeyError, key
         else:
