Fix a clang warning in grammar.c

vstinner · vstinner · commit 4bb31e90f0ec · 2016-08-19T15:11:56.000+02:00
Clang is smarter than GCC and emits a warning for dead code after a function
declared with __attribute__((__noreturn__)) (Py_FatalError).
diff --git a/Parser/grammar.c b/Parser/grammar.c
@@ -122,7 +122,13 @@ findlabel(labellist *ll, int type, const char *str)
     }
     fprintf(stderr, "Label %d/'%s' not found\n", type, str);
     Py_FatalError("grammar.c:findlabel()");
+
+    /* Py_FatalError() is declared with __attribute__((__noreturn__)).
+       GCC emits a warning without "return 0;" (compiler bug!), but Clang is
+       smarter and emits a warning on the return... */
+#ifndef __clang__
     return 0; /* Make gcc -Wall happy */
+#endif
 }
 
 /* Forward */

Original file line number	Diff line number	Diff line change
`@@ -122,7 +122,13 @@ findlabel(labellist ll, int type, const char str)`
`122`	`122`	`}`
`123`	`123`	`fprintf(stderr, "Label %d/'%s' not found\n", type, str);`
`124`	`124`	`Py_FatalError("grammar.c:findlabel()");`
	`125`	`+`
	`126`	`+ /* Py_FatalError() is declared with __attribute__((__noreturn__)).`
	`127`	`+ GCC emits a warning without "return 0;" (compiler bug!), but Clang is`
	`128`	`+ smarter and emits a warning on the return... */`
	`129`	`+#ifndef __clang__`
`125`	`130`	`return 0; /* Make gcc -Wall happy */`
	`131`	`+#endif`
`126`	`132`	`}`
`127`	`133`
`128`	`134`	`/* Forward */`