Issue #27942: Fix memory leak in codeobject.c

1st1 · 1st1 · commit 48aa605337a8 · 2016-11-09T09:41:15.000-05:00
diff --git a/Objects/codeobject.c b/Objects/codeobject.c
@@ -65,6 +65,7 @@ intern_string_constants(PyObject *tuple)
             intern_string_constants(v);
         }
         else if (PyFrozenSet_CheckExact(v)) {
+            PyObject *w = v;
             PyObject *tmp = PySequence_Tuple(v);
             if (tmp == NULL) {
                 PyErr_Clear();
@@ -77,6 +78,7 @@ intern_string_constants(PyObject *tuple)
                 }
                 else {
                     PyTuple_SET_ITEM(tuple, i, v);
+                    Py_DECREF(w);
                     modified = 1;
                 }
             }

Original file line number	Diff line number	Diff line change
`@@ -65,6 +65,7 @@ intern_string_constants(PyObject *tuple)`
`65`	`65`	`intern_string_constants(v);`
`66`	`66`	`}`
`67`	`67`	`else if (PyFrozenSet_CheckExact(v)) {`
	`68`	`+ PyObject *w = v;`
`68`	`69`	`PyObject *tmp = PySequence_Tuple(v);`
`69`	`70`	`if (tmp == NULL) {`
`70`	`71`	`PyErr_Clear();`
`@@ -77,6 +78,7 @@ intern_string_constants(PyObject *tuple)`
`77`	`78`	`}`
`78`	`79`	`else {`
`79`	`80`	`PyTuple_SET_ITEM(tuple, i, v);`
	`81`	`+ Py_DECREF(w);`
`80`	`82`	`modified = 1;`
`81`	`83`	`}`
`82`	`84`	`}`