Statistics inv_cdf sync with corresponding random module normal distributions (#95265)

rhettinger · web-flow · commit 4395ff1e6a18 · 2022-07-26T02:23:33.000-05:00
diff --git a/Lib/statistics.py b/Lib/statistics.py
@@ -1221,8 +1221,6 @@ def inv_cdf(self, p):
         """
         if p <= 0.0 or p >= 1.0:
             raise StatisticsError('p must be in the range 0.0 < p < 1.0')
-        if self._sigma <= 0.0:
-            raise StatisticsError('cdf() not defined when sigma at or below zero')
         return _normal_dist_inv_cdf(p, self._mu, self._sigma)
 
     def quantiles(self, n=4):
diff --git a/Lib/test/test_statistics.py b/Lib/test/test_statistics.py
@@ -2801,9 +2801,10 @@ def test_inv_cdf(self):
             iq.inv_cdf(1.0)                         # p is one
         with self.assertRaises(self.module.StatisticsError):
             iq.inv_cdf(1.1)                         # p over one
-        with self.assertRaises(self.module.StatisticsError):
-            iq = NormalDist(100, 0)                 # sigma is zero
-            iq.inv_cdf(0.5)
+
+        # Supported case:
+        iq = NormalDist(100, 0)                     # sigma is zero
+        self.assertEqual(iq.inv_cdf(0.5), 100)
 
         # Special values
         self.assertTrue(math.isnan(Z.inv_cdf(float('NaN'))))
diff --git a/Modules/_statisticsmodule.c b/Modules/_statisticsmodule.c
@@ -31,7 +31,7 @@ _statistics__normal_dist_inv_cdf_impl(PyObject *module, double p, double mu,
 /*[clinic end generated code: output=02fd19ddaab36602 input=24715a74be15296a]*/
 {
     double q, num, den, r, x;
-    if (p <= 0.0 || p >= 1.0 || sigma <= 0.0) {
+    if (p <= 0.0 || p >= 1.0) {
         goto error;
     }
 

Original file line number	Diff line number	Diff line change
`@@ -31,7 +31,7 @@ _statistics__normal_dist_inv_cdf_impl(PyObject *module, double p, double mu,`
`31`	`31`	`/[clinic end generated code: output=02fd19ddaab36602 input=24715a74be15296a]/`
`32`	`32`	`{`
`33`	`33`	`double q, num, den, r, x;`
`34`		`- if (p <= 0.0 \|\| p >= 1.0 \|\| sigma <= 0.0) {`
	`34`	`+ if (p <= 0.0 \|\| p >= 1.0) {`
`35`	`35`	`goto error;`
`36`	`36`	`}`
`37`	`37`