bpo-35470: Fix a reference counting bug in _PyImport_FindExtensionObjectEx(). (GH-11128)

miss-islington · ZackerySpytz · web-flow · commit 3e3d57d8490b · 2019-01-10T08:36:50.000-08:00
(cherry picked from commit 89c4f90) Co-authored-by: Zackery Spytz <zspytz@gmail.com>
diff --git a/Python/import.c b/Python/import.c
@@ -743,7 +743,6 @@ _PyImport_FindExtensionObjectEx(PyObject *name, PyObject *filename,
     }
     if (_PyState_AddModule(mod, def) < 0) {
         PyMapping_DelItem(modules, name);
-        Py_DECREF(mod);
         return NULL;
     }
     if (Py_VerboseFlag)

Original file line number	Diff line number	Diff line change
`@@ -743,7 +743,6 @@ _PyImport_FindExtensionObjectEx(PyObject name, PyObject filename,`
`743`	`743`	`}`
`744`	`744`	`if (_PyState_AddModule(mod, def) < 0) {`
`745`	`745`	`PyMapping_DelItem(modules, name);`
`746`		`- Py_DECREF(mod);`
`747`	`746`	`return NULL;`
`748`	`747`	`}`
`749`	`748`	`if (Py_VerboseFlag)`