Remove buggy assertion in PyUnicode_Substring()

vstinner · vstinner · commit 3a7f7977f1ad · 2012-05-03T03:36:40.000+02:00
Use also directly unicode_empty, instead of PyUnicode_New(0,0).
diff --git a/Objects/unicodeobject.c b/Objects/unicodeobject.c
@@ -12078,8 +12078,8 @@ PyUnicode_Substring(PyObject *self, Py_ssize_t start, Py_ssize_t end)
         return NULL;
     }
     if (start >= length || end < start) {
-        assert(end == length);
-        return PyUnicode_New(0, 0);
+        Py_INCREF(unicode_empty);
+        return unicode_empty;
     }
 
     length = end - start;

Original file line number	Diff line number	Diff line change
`@@ -12078,8 +12078,8 @@ PyUnicode_Substring(PyObject *self, Py_ssize_t start, Py_ssize_t end)`
`12078`	`12078`	`return NULL;`
`12079`	`12079`	`}`
`12080`	`12080`	`if (start >= length \|\| end < start) {`
`12081`		`- assert(end == length);`
`12082`		`- return PyUnicode_New(0, 0);`
	`12081`	`+ Py_INCREF(unicode_empty);`
	`12082`	`+ return unicode_empty;`
`12083`	`12083`	`}`
`12084`	`12084`
`12085`	`12085`	`length = end - start;`