PyCodec_ReplaceErrors() uses "C" format instead of "u#" to build result

Victor Stinner · Victor Stinner · commit 1a15aba71d45 · 2011-10-02T19:00:15.000+02:00
diff --git a/Python/codecs.c b/Python/codecs.c
@@ -534,10 +534,11 @@ PyObject *PyCodec_ReplaceErrors(PyObject *exc)
         return Py_BuildValue("(Nn)", res, end);
     }
     else if (PyObject_IsInstance(exc, PyExc_UnicodeDecodeError)) {
-        Py_UNICODE res = Py_UNICODE_REPLACEMENT_CHARACTER;
         if (PyUnicodeDecodeError_GetEnd(exc, &end))
             return NULL;
-        return Py_BuildValue("(u#n)", &res, 1, end);
+        return Py_BuildValue("(Cn)",
+                             (int)Py_UNICODE_REPLACEMENT_CHARACTER,
+                             end);
     }
     else if (PyObject_IsInstance(exc, PyExc_UnicodeTranslateError)) {
         PyObject *res;

Original file line number	Diff line number	Diff line change
`@@ -534,10 +534,11 @@ PyObject PyCodec_ReplaceErrors(PyObject exc)`
`534`	`534`	`return Py_BuildValue("(Nn)", res, end);`
`535`	`535`	`}`
`536`	`536`	`else if (PyObject_IsInstance(exc, PyExc_UnicodeDecodeError)) {`
`537`		`- Py_UNICODE res = Py_UNICODE_REPLACEMENT_CHARACTER;`
`538`	`537`	`if (PyUnicodeDecodeError_GetEnd(exc, &end))`
`539`	`538`	`return NULL;`
`540`		`- return Py_BuildValue("(u#n)", &res, 1, end);`
	`539`	`+ return Py_BuildValue("(Cn)",`
	`540`	`+ (int)Py_UNICODE_REPLACEMENT_CHARACTER,`
	`541`	`+ end);`
`541`	`542`	`}`
`542`	`543`	`else if (PyObject_IsInstance(exc, PyExc_UnicodeTranslateError)) {`
`543`	`544`	`PyObject *res;`