Skip to content

Commit b0e97f0

Browse files
committed
Apply code review suggestions.
1 parent 5ac6546 commit b0e97f0

1 file changed

Lines changed: 3 additions & 7 deletions

File tree

jit/tests/common.rs

Lines changed: 3 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -128,17 +128,13 @@ impl StackMachine {
128128
let mut values = Vec::new();
129129

130130
// Pop all values from stack:
131-
for _ in 0..amount {
132-
values.push(self.stack.pop().unwrap());
133-
}
131+
values.extend(self.stack.drain(self.stack.len() - amount..));
134132

135133
// Push top of stack back first:
136-
self.stack.push(values.remove(0));
134+
self.stack.push(values.pop().unwrap());
137135

138136
// Push other value back in order:
139-
for value in values.into_iter().rev() {
140-
self.stack.push(value);
141-
}
137+
self.stack.extend(values);
142138
}
143139
Instruction::ReturnValue => return true,
144140
_ => unimplemented!(

0 commit comments

Comments
 (0)