add arg_name in duplicate argument error msg

nicku12345 · nicku12345 · commit 2c09785b7acf · 2022-12-29T22:49:26.000+08:00
diff --git a/compiler/parser/src/error.rs b/compiler/parser/src/error.rs
@@ -21,7 +21,7 @@ pub enum LexicalErrorType {
     TabError,
     TabsAfterSpaces,
     DefaultArgumentError,
-    DuplicateArgumentError,
+    DuplicateArgumentError(String),
     PositionalArgumentError,
     UnpackedArgumentError,
     DuplicateKeywordArgumentError,
@@ -51,8 +51,8 @@ impl fmt::Display for LexicalErrorType {
             LexicalErrorType::DefaultArgumentError => {
                 write!(f, "non-default argument follows default argument")
             }
-            LexicalErrorType::DuplicateArgumentError => {
-                write!(f, "duplicate argument in function definition")
+            LexicalErrorType::DuplicateArgumentError(arg_name) => {
+                write!(f, "duplicate argument '{arg_name}' in function definition")
             }
             LexicalErrorType::DuplicateKeywordArgumentError => {
                 write!(f, "keyword argument repeated")
diff --git a/compiler/parser/src/function.rs b/compiler/parser/src/function.rs
@@ -31,16 +31,16 @@ pub fn validate_arguments(
     let mut all_arg_names =
         FxHashSet::with_hasher(Default::default());
     for arg in all_args {
-        let arg_name = arg.node.arg.clone();
+        let arg_name = &arg.node.arg;
         if !all_arg_names.insert(arg_name) {
             return Err(LexicalError {
-                error: LexicalErrorType::DuplicateArgumentError,
+                error: LexicalErrorType::DuplicateArgumentError(arg_name.to_string()),
                 location: arg.location,
             });
         }
     }
 
-    return Ok(arguments);
+    Ok(arguments)
 }
 
 pub fn parse_params(

Original file line number	Diff line number	Diff line change
`@@ -31,16 +31,16 @@ pub fn validate_arguments(`
`31`	`31`	`let mut all_arg_names =`
`32`	`32`	`FxHashSet::with_hasher(Default::default());`
`33`	`33`	`for arg in all_args {`
`34`		`- let arg_name = arg.node.arg.clone();`
	`34`	`+ let arg_name = &arg.node.arg;`
`35`	`35`	`if !all_arg_names.insert(arg_name) {`
`36`	`36`	`return Err(LexicalError {`
`37`		`- error: LexicalErrorType::DuplicateArgumentError,`
	`37`	`+ error: LexicalErrorType::DuplicateArgumentError(arg_name.to_string()),`
`38`	`38`	`location: arg.location,`
`39`	`39`	`});`
`40`	`40`	`}`
`41`	`41`	`}`
`42`	`42`
`43`		`- return Ok(arguments);`
	`43`	`+ Ok(arguments)`
`44`	`44`	`}`
`45`	`45`
`46`	`46`	`pub fn parse_params(`