add overflow errors for int shifts.

alexpantyukhin · alexpantyukhin · commit 15e618758353 · 2019-02-27T11:11:38.000+04:00
diff --git a/tests/snippets/ints.py b/tests/snippets/ints.py
@@ -1,3 +1,5 @@
+from testutils import assert_raises
+
 # int to int comparisons
 
 assert 1 == 1
@@ -36,6 +38,7 @@
 assert (1).real == 1
 assert (1).imag == 0
 
+assert_raises(OverflowError, lambda: 1 << 10 ** 100000)
 
 assert (1).__eq__(1.0) == NotImplemented
 assert (1).__ne__(1.0) == NotImplemented
diff --git a/vm/src/obj/objint.rs b/vm/src/obj/objint.rs
@@ -246,8 +246,7 @@ fn int_lshift(vm: &mut VirtualMachine, args: PyFuncArgs) -> PyResult {
     match get_value(i2) {
         ref v if *v < BigInt::zero() => Err(vm.new_value_error("negative shift count".to_string())),
         ref v if *v > BigInt::from(usize::max_value()) => {
-            // TODO: raise OverflowError
-            panic!("Failed converting {} to rust usize", get_value(i2));
+            Err(vm.new_overflow_error("the number is too large to convert to float".to_string()))
         }
         _ => panic!("Failed converting {} to rust usize", get_value(i2)),
     }
@@ -276,8 +275,7 @@ fn int_rshift(vm: &mut VirtualMachine, args: PyFuncArgs) -> PyResult {
     match get_value(i2) {
         ref v if *v < BigInt::zero() => Err(vm.new_value_error("negative shift count".to_string())),
         ref v if *v > BigInt::from(usize::max_value()) => {
-            // TODO: raise OverflowError
-            panic!("Failed converting {} to rust usize", get_value(i2));
+            Err(vm.new_overflow_error("the number is too large to convert to float".to_string()))
         }
         _ => panic!("Failed converting {} to rust usize", get_value(i2)),
     }

Original file line number	Diff line number	Diff line change
`@@ -246,8 +246,7 @@ fn int_lshift(vm: &mut VirtualMachine, args: PyFuncArgs) -> PyResult {`
`246`	`246`	`match get_value(i2) {`
`247`	`247`	`ref v if *v < BigInt::zero() => Err(vm.new_value_error("negative shift count".to_string())),`
`248`	`248`	`ref v if *v > BigInt::from(usize::max_value()) => {`
`249`		`- // TODO: raise OverflowError`
`250`		`- panic!("Failed converting {} to rust usize", get_value(i2));`
	`249`	`+ Err(vm.new_overflow_error("the number is too large to convert to float".to_string()))`
`251`	`250`	`}`
`252`	`251`	`_ => panic!("Failed converting {} to rust usize", get_value(i2)),`
`253`	`252`	`}`
`@@ -276,8 +275,7 @@ fn int_rshift(vm: &mut VirtualMachine, args: PyFuncArgs) -> PyResult {`
`276`	`275`	`match get_value(i2) {`
`277`	`276`	`ref v if *v < BigInt::zero() => Err(vm.new_value_error("negative shift count".to_string())),`
`278`	`277`	`ref v if *v > BigInt::from(usize::max_value()) => {`
`279`		`- // TODO: raise OverflowError`
`280`		`- panic!("Failed converting {} to rust usize", get_value(i2));`
	`278`	`+ Err(vm.new_overflow_error("the number is too large to convert to float".to_string()))`
`281`	`279`	`}`
`282`	`280`	`_ => panic!("Failed converting {} to rust usize", get_value(i2)),`
`283`	`281`	`}`