Fix esbuild treating warnings as errors (anomalyco#1167)

thdxr · web-flow · commit 45f92b5e221a · 2021-12-20T10:25:06.000-05:00
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -17,7 +17,7 @@ jobs:
     strategy:
       matrix:
         os: [ubuntu-latest, windows-latest]
-        node-version: [14.x, 16.8]
+        node-version: [12.x, 14.x, 16.8]
     runs-on: ${{ matrix.os }}
 
     steps:
diff --git a/packages/core/src/runtime/handler/node.ts b/packages/core/src/runtime/handler/node.ts
@@ -139,10 +139,15 @@ export const NodeHandler: Definition<Bundle> = (opts) => {
             ...config,
             plugins,
           })}
-          esbuild.build({
-            ...config,
-            plugins: config.plugins ? require(config.plugins) : undefined
-          })
+          try {
+            await esbuild.build({
+              ...config,
+              plugins: config.plugins ? require(config.plugins) : undefined
+            })
+            process.exit(0)
+          } catch {
+            process.exit(1)
+          }
         }
         run()
       `;
@@ -153,11 +158,14 @@ export const NodeHandler: Definition<Bundle> = (opts) => {
       const result = spawn.sync("node", [builder], {
         stdio: "pipe",
       });
-      const err = (result.stderr.toString() + result.stdout.toString()).trim();
-      if (err)
+      if (result.status !== 0) {
+        const err = (
+          result.stderr.toString() + result.stdout.toString()
+        ).trim();
         throw new Error(
           "There was a problem transpiling the Lambda handler: " + err
         );
+      }
 
       fs.removeSync(builder);
 
