Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: purescript/purescript-foldable-traversable
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Choose a base ref
...
head repository: purescript-lua/purescript-lua-foldable-traversable
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: master
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 15 commits
  • 35 files changed
  • 5 contributors

Commits on Apr 22, 2023

  1. Lua

    Unisay committed Apr 22, 2023
    Configuration menu
    Copy the full SHA
    1102dc5 View commit details
    Browse the repository at this point in the history

Commits on Mar 30, 2024

  1. Wrapped foreigns

    Unisay committed Mar 30, 2024
    Configuration menu
    Copy the full SHA
    18a7d55 View commit details
    Browse the repository at this point in the history

Commits on Oct 25, 2025

  1. Configuration menu
    Copy the full SHA
    6607e57 View commit details
    Browse the repository at this point in the history
  2. Fix: consider array indexing starting from 1 in lua

    Traverse used JS implementation which is OK except that the array indexing was starting from 0.
    Renegatto authored Oct 25, 2025
    Configuration menu
    Copy the full SHA
    c129cb5 View commit details
    Browse the repository at this point in the history

Commits on Jun 14, 2026

  1. Merge pull request #2 from Renegatto/alexey/fix-append

    Fix `traverse` failing at runtime
    Unisay authored Jun 14, 2026
    Configuration menu
    Copy the full SHA
    15afbd7 View commit details
    Browse the repository at this point in the history
  2. chore: finalize traverse fix — mapWithIndex, regression test, tooling

    Follows the merged traverse fix (#2 by @Renegatto). On top of it:
    
    - Fix mapWithIndexArray: it passed the 1-based Lua loop index to f, but
      PureScript mapWithIndex is 0-based, so f received i instead of i-1
      (originally reported in #1 by @sarahnya).
    - Add a focused regression suite (test-regression/) run by scripts/test:
      traverse over Maybe is length/order-preserving at every size (>3 hits
      the pivot/append branch, which needs the Array Semigroup fix shipped in
      prelude v7.2.2), traverse over the Array applicative, and 0-based
      mapWithIndex.
    - Align tooling: purescript-overlay dev shell on Lua 5.1 (drops easy-ps /
      insecure nodejs), canonical nix CI replacing the bower workflow,
      fail-fast scripts, and bump the package set to psc-0.15.15-20260614
      (prelude v7.2.2). Supersedes the earlier normalization PR #3.
    
    Closes #1
    Unisay committed Jun 14, 2026
    Configuration menu
    Copy the full SHA
    2ca0161 View commit details
    Browse the repository at this point in the history
  3. Merge pull request #4 from Unisay/chore/finalize-traverse

    chore: finalize traverse fix — mapWithIndex, regression test, tooling alignment
    Unisay authored Jun 14, 2026
    Configuration menu
    Copy the full SHA
    78a544d View commit details
    Browse the repository at this point in the history
  4. chore: align CI to hardened canon, add AGENTS.md + CLAUDE.md

    CI: drop accept-flake-config (supply-chain risk; caches already pinned),
    run luacheck with --std lua51 --no-unused-args (matches the Lua 5.1 target
    and the curried-FFI idiom), invoke the test step via bash so it no longer
    needs the execute bit.
    
    AGENTS.md is the single instruction file the coding agents read natively;
    CLAUDE.md is a one-line @AGENTS.md import so Claude Code shares it. Also
    removes dead JavaScript-era package files. Tooling and docs only, no src/.
    Unisay committed Jun 14, 2026
    Configuration menu
    Copy the full SHA
    3ea587c View commit details
    Browse the repository at this point in the history
  5. Merge pull request #5 from Unisay/chore/agents-md-and-canon-ci

    chore: align CI to the hardened canon, add AGENTS.md
    Unisay authored Jun 14, 2026
    Configuration menu
    Copy the full SHA
    72d75f5 View commit details
    Browse the repository at this point in the history
  6. chore: point pslua + package-set links at purescript-lua org

    Repos moved from Unisay/* to the purescript-lua org. Update the pslua
    flake input and lockfile owner (same rev 94c13ce), the packages.dhall
    upstream-lua release URL, and the AGENTS.md links, so nothing relies on
    the old-owner redirect.
    Unisay committed Jun 14, 2026
    Configuration menu
    Copy the full SHA
    76cb103 View commit details
    Browse the repository at this point in the history
  7. Merge pull request #6 from purescript-lua/chore/migrate-org-links

    chore: point pslua + package-set links at purescript-lua org
    Unisay authored Jun 14, 2026
    Configuration menu
    Copy the full SHA
    7275430 View commit details
    Browse the repository at this point in the history
  8. chore: add treefmt formatting (nix fmt) and format the tree

    Wire treefmt via treefmt-nix: nixfmt, dhall format, purs-tidy (.tidyrc.json)
    and LuaFormatter for the FFI (.lua-format, kept over StyLua because it
    preserves the parentheses pslua's parser needs). `nix fmt` formats; the dev
    shell installs a content-based pre-commit hook and CI runs
    `nix fmt && git diff --exit-code` (content-based, since the in-place
    formatters bump mtime and would trip treefmt --fail-on-change). Lua lines
    budget 130 cols, matching the raised `luacheck --max-line-length`. The bulk
    of the diff is the first format pass.
    Unisay committed Jun 14, 2026
    Configuration menu
    Copy the full SHA
    08d9714 View commit details
    Browse the repository at this point in the history

Commits on Jun 15, 2026

  1. Merge pull request #7 from purescript-lua/chore/treefmt

    chore: add treefmt formatting (nix fmt + pre-commit + CI check)
    Unisay authored Jun 15, 2026
    Configuration menu
    Copy the full SHA
    5fb83f6 View commit details
    Browse the repository at this point in the history
  2. chore: harden pre-commit hook (tracked .githooks/ + core.hooksPath)

    Replace the dev-shell installer that wrote .git/hooks/pre-commit with a
    tracked .githooks/pre-commit wired via `git config core.hooksPath .githooks`.
    
    Fixes three issues with the old hook: it gated on `[ -d .git ]` (false in
    worktrees/submodules where .git is a file), it clobbered any existing
    .git/hooks/pre-commit on every `nix develop`, and `nix fmt … || exit 0`
    swallowed real formatter failures. The new hook skips only when `nix` is
    absent (CI is the authoritative gate) and otherwise blocks on a `nix fmt`
    failure or reformat.
    Unisay committed Jun 15, 2026
    Configuration menu
    Copy the full SHA
    a35bc5d View commit details
    Browse the repository at this point in the history
  3. chore: bump pslua dev input to 62e3653

    Toolchain consistency: pin the pslua dev flake input to the current
    compiler main across the ecosystem. flake.lock only; the package set
    consumes sources + FFI, not this dev input, so no re-tag is needed.
    Unisay committed Jun 15, 2026
    Configuration menu
    Copy the full SHA
    7ac4982 View commit details
    Browse the repository at this point in the history
Loading