Skip to content

Commit 200e39c

Browse files
committed
outdated_state: omit 0. and 1. versions
1 parent 1e61abf commit 200e39c

2 files changed

Lines changed: 7 additions & 1 deletion

File tree

lib/docs/core/doc.rb

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -203,6 +203,8 @@ def outdated_state(scraper_version, latest_version)
203203
[0, 1].each do |i|
204204
break if i >= scraper_parts.length or i >= latest_parts.length
205205
return 'Outdated major version' if i == 0 and latest_parts[i] > scraper_parts[i]
206+
return 'Outdated major version' if i == 1 and latest_parts[i] > scraper_parts[i] and latest_parts[0] == 0 and scraper_parts[0] == 0
207+
return 'Outdated major version' if i == 1 and latest_parts[i] > scraper_parts[i] and latest_parts[0] == 1 and scraper_parts[0] == 1
206208
return 'Outdated minor version' if i == 1 and latest_parts[i] > scraper_parts[i]
207209
return 'Up-to-date' if latest_parts[i] < scraper_parts[i]
208210
end

test/lib/docs/core/doc_test.rb

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -390,12 +390,16 @@ class DocsDocTest < MiniTest::Spec
390390

391391
it "compares versions" do
392392
instance = doc.versions.first.new
393+
assert_equal "Up-to-date", instance.outdated_state('0.0.2', '0.0.3')
394+
assert_equal "Outdated major version", instance.outdated_state('0.2', '0.3')
393395
assert_equal 'Up-to-date', instance.outdated_state('1', '1')
394396
assert_equal 'Up-to-date', instance.outdated_state('1.2', '1.2')
395397
assert_equal 'Up-to-date', instance.outdated_state('1.2.2', '1.2.2')
396398
assert_equal 'Up-to-date', instance.outdated_state('1.2.2', '1.2.3')
397399
assert_equal "Outdated major version", instance.outdated_state('1', '2')
398-
assert_equal "Outdated minor version", instance.outdated_state('1.2', '1.3')
400+
assert_equal "Up-to-date", instance.outdated_state('1.0.2', '1.0.3')
401+
assert_equal "Outdated major version", instance.outdated_state('1.2', '1.3')
402+
assert_equal "Outdated minor version", instance.outdated_state('2.2', '2.3')
399403
assert_equal "Outdated major version", instance.outdated_state('9', '10')
400404
assert_equal "Outdated major version", instance.outdated_state('99', '101')
401405
assert_equal 'Up-to-date', instance.outdated_state('2006-01-02', '2006-01-03')

0 commit comments

Comments
 (0)