Skip to content

Commit cad783c

Browse files
committed
Fix filewriting bug.
1 parent c669354 commit cad783c

File tree

2 files changed

+9
-5
lines changed

2 files changed

+9
-5
lines changed

src/chrome/content/code/HTTPSRules.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -266,13 +266,13 @@ const RuleWriter = {
266266
write: function(file, data) {
267267
//if (!file.exists())
268268
// return null;
269-
this.log(WARN, "Opening " + file.path + "for writing");
270-
var data = "";
269+
this.log(WARN, "Opening " + file.path + " for writing");
271270
var fstream = CC["@mozilla.org/network/file-output-stream;1"]
272271
.createInstance(CI.nsIFileOutputStream);
273272
fstream.init(file, -1, -1, 0);
274273

275-
fstream.write(data, data.length);
274+
var retval = fstream.write(data, data.length);
275+
this.log(WARN, "Got retval " + retval);
276276
fstream.close();
277277
return data;
278278
},

src/components/ssl-observatory.js

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -149,6 +149,7 @@ function SSLObservatory() {
149149

150150
//this.updateCertWhitelist();
151151
this.loadCertWhitelist();
152+
this.saveCertWhitelist();
152153

153154
this.log(DBUG, "Loaded observatory component!");
154155
}
@@ -545,7 +546,10 @@ SSLObservatory.prototype = {
545546
var file =
546547
CC["@mozilla.org/file/local;1"]
547548
.createInstance(CI.nsILocalFile);
548-
file.initWithPath(this.HTTPSEverywhere.rw.chromeToPath(loc));
549+
var path = this.HTTPSEverywhere.rw.chromeToPath(loc);
550+
this.log(WARN,"SAVING cert whitelist to " + path);
551+
file.initWithPath(path);
552+
this.log(WARN,"got " + file);
549553
var data = this.HTTPSEverywhere.rw.write(file, JSON.stringify(this.whitelist));
550554
},
551555

@@ -580,7 +584,7 @@ SSLObservatory.prototype = {
580584
that.log(4, "Replacing chain whitelist...");
581585
that.whitelist = whitelist;
582586
that.log(5, "Got valid whitelist..." + JSON.stringify(whitelist));
583-
that.saveCertWhitelist();
587+
that.updateCertWhitelist();
584588
} else {
585589
that.log(4, "Unexpected response status " + req.status + " fetching chain whitelist");
586590
return false;

0 commit comments

Comments
 (0)