Skip to content

generated code incorrectly refers to $util instead of util #732

Closed

Description

@tamird

In CockroachDB we have some protos in the util package, but the protobufjs generated code trips on this and generates code like this:

            UnresolvedAddr.decode = function decode(reader, length) {
                if (!(reader instanceof $Reader))
                    reader = $Reader.create(reader);
                let end = length === undefined ? reader.len : reader.pos + length, message = new $root.cockroach.$util.UnresolvedAddr();
                while (reader.pos < end) {
                    let tag = reader.uint32();
                    switch (tag >>> 3) {
                    case 1:
                        message.network_field = reader.string();
                        break;
                    case 2:
                        message.address_field = reader.string();
                        break;
                    default:
                        reader.skipType(tag & 7);
                        break;
                    }
                }
                return message;
            };

Note that $root.cockroach.$util should be $root.cockroach.util.

Activity

  1. dcodeIO commented on Mar 27, 2017

    @dcodeIO
    Member

    Got a bit lost in espree's AST so please let me know if this fixes your issue(s). Might affect the PR.

  2. tamird commented on Mar 27, 2017

    @tamird
    Author

    Fixes my issue, hurray! Rebased the PR as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions