fix: Restore first-match namespace lookup (#2236)

dcodeIO · web-flow · commit cc7d59559d4e · 2026-05-09T07:38:16.000+02:00
diff --git a/src/namespace.js b/src/namespace.js
@@ -466,8 +466,10 @@ Namespace.prototype._lookupImpl = function lookup(path, flatPath) {
     // Otherwise try each nested namespace
     } else {
         for (var i = 0; i < this.nestedArray.length; ++i)
-            if (this._nestedArray[i] instanceof Namespace && (found = this._nestedArray[i]._lookupImpl(path, flatPath)))
+            if (this._nestedArray[i] instanceof Namespace && (found = this._nestedArray[i]._lookupImpl(path, flatPath))) {
                 exact = found;
+                break;
+            }
     }
 
     // Set this even when null, so that when we walk up the tree we can quickly bail on repeated checks back down.
diff --git a/tests/api_namespace.js b/tests/api_namespace.js
@@ -114,6 +114,27 @@ tape.test("reflected namespaces", function(test) {
     test.equal(specialRoot.lookup("__proto__"), null, "should ignore reserved nested object names");
     test.equal(Object.getPrototypeOf(specialRoot._lookupCache), null, "should isolate lookup cache keys");
 
+    var fallbackRoot = protobuf.Root.fromJSON({
+        nested: {
+            A: {
+                nested: {
+                    Point3D: { fields: {} }
+                }
+            },
+            C: {
+                nested: {
+                    Point3D: { fields: {} }
+                }
+            },
+            B: {
+                fields: {
+                    p: { type: "Point3D", id: 1 }
+                }
+            }
+        }
+    }).resolveAll();
+    test.equal(fallbackRoot.lookupType("B").fields.p.resolvedType.fullName, ".A.Point3D", "should preserve legacy first-match nested fallback lookup");
+
     ns = protobuf.Namespace.fromJSON("My", {
         nested: {
             Message: { fields: {} },
