Skip to content

Commit b24d8bc

Browse files
committed
Fix failing tests
1 parent 9eff91b commit b24d8bc

5 files changed

Lines changed: 18 additions & 12 deletions

File tree

Sources/Controllers/MessagesViewController.swift

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
1+
12
/*
23
MIT License
34

Sources/Views/Cells/MessageCollectionViewCell.swift

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,12 @@ open class MessageCollectionViewCell: UICollectionViewCell, CollectionViewReusab
3232

3333
open var avatarView = AvatarView()
3434

35-
open var messageContainerView = MessageContainerView()
35+
open var messageContainerView: MessageContainerView = {
36+
let containerView = MessageContainerView()
37+
containerView.clipsToBounds = true
38+
containerView.layer.masksToBounds = true
39+
return containerView
40+
}()
3641

3742
open var cellTopLabel: UILabel = {
3843
let label = UILabel()
@@ -50,6 +55,7 @@ open class MessageCollectionViewCell: UICollectionViewCell, CollectionViewReusab
5055

5156
override public init(frame: CGRect) {
5257
super.init(frame: frame)
58+
contentView.autoresizingMask = [.flexibleWidth, .flexibleHeight]
5359
setupSubviews()
5460
setupGestureRecognizers()
5561
}

Tests/ControllersTest/MessagesViewControllerTests.swift

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,6 +40,7 @@ class MessagesViewControllerTests: XCTestCase {
4040

4141
sut = MessagesViewController()
4242
sut.messagesCollectionView.messagesLayoutDelegate = layoutDelegate
43+
sut.messagesCollectionView.messagesDisplayDelegate = layoutDelegate
4344
_ = sut.view
4445
sut.beginAppearanceTransition(true, animated: true)
4546
sut.endAppearanceTransition()
@@ -193,7 +194,7 @@ class MessagesViewControllerTests: XCTestCase {
193194

194195
}
195196

196-
private class MockLayoutDelegate: MessagesLayoutDelegate {
197+
private class MockLayoutDelegate: MessagesLayoutDelegate, MessagesDisplayDelegate {
197198

198199
// MARK: - LocationMessageLayoutDelegate
199200

Tests/ProtocolsTests/MessagesDisplayDelegateTests.swift

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -243,15 +243,16 @@ private class MockMessagesViewController: MessagesViewController, MessagesDispla
243243
return 200
244244
}
245245

246-
247246
var dataProvider: MockMessagesDataSource!
248247

249248
override func viewDidLoad() {
250249
super.viewDidLoad()
251250

252251
dataProvider = makeDataSource()
252+
messagesCollectionView.messagesDisplayDelegate = self
253253
messagesCollectionView.messagesDataSource = dataProvider
254254
messagesCollectionView.messagesLayoutDelegate = self
255+
255256
}
256257

257258
private func makeDataSource() -> MockMessagesDataSource {

Tests/ViewsTests/MessageCollectionViewCellTests.swift

Lines changed: 6 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ import XCTest
2727

2828
class MessageCollectionViewCellTests: XCTestCase {
2929

30-
var cell: MessageCollectionViewCell<UIView>!
30+
var cell: MessageCollectionViewCell!
3131
let frame = CGRect(x: 0, y: 0, width: 100, height: 100)
3232

3333
override func setUp() {
@@ -42,20 +42,18 @@ class MessageCollectionViewCellTests: XCTestCase {
4242

4343
func testInit() {
4444
XCTAssertEqual(cell.contentView.autoresizingMask, [.flexibleWidth, .flexibleHeight])
45-
XCTAssertEqual(cell.contentView.subviews, [cell.cellTopLabel, cell.messageContainerView, cell.avatarView, cell.cellBottomLabel])
46-
XCTAssertEqual(cell.messageContainerView.subviews, [cell.messageContentView])
45+
XCTAssert(cell.contentView.subviews.contains(cell.cellTopLabel))
46+
XCTAssert(cell.contentView.subviews.contains(cell.cellBottomLabel))
47+
XCTAssert(cell.contentView.subviews.contains(cell.avatarView))
48+
XCTAssert(cell.contentView.subviews.contains(cell.messageContainerView))
49+
4750
}
4851

4952
func testMessageContainerViewPropertiesSetup() {
5053
XCTAssertTrue(cell.messageContainerView.clipsToBounds)
5154
XCTAssertTrue(cell.messageContainerView.layer.masksToBounds)
5255
}
5356

54-
func testMessageContentViewPropertiesSetup() {
55-
XCTAssertTrue(cell.messageContentView.clipsToBounds)
56-
XCTAssertTrue(cell.messageContentView.isUserInteractionEnabled)
57-
}
58-
5957
func testPrepareForReuse() {
6058
cell.prepareForReuse()
6159
XCTAssertNil(cell.cellTopLabel.text)
@@ -70,7 +68,6 @@ class MessageCollectionViewCellTests: XCTestCase {
7068

7169
XCTAssertEqual(cell.avatarView.frame, layoutAttributes.frame)
7270
XCTAssertEqual(cell.messageContainerView.frame, layoutAttributes.messageContainerFrame)
73-
XCTAssertEqual(cell.messageContentView.frame, cell.messageContainerView.frame)
7471
XCTAssertEqual(cell.cellTopLabel.frame, layoutAttributes.topLabelFrame)
7572
XCTAssertEqual(cell.cellBottomLabel.frame, layoutAttributes.bottomLabelFrame)
7673
}

0 commit comments

Comments
 (0)